Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to TypeScript v5.1 #4370

Closed
MajorLift opened this issue Jun 5, 2024 · 6 comments · Fixed by #4576
Closed

Upgrade to TypeScript v5.1 #4370

MajorLift opened this issue Jun 5, 2024 · 6 comments · Fixed by #4576
Assignees

Comments

@MajorLift
Copy link
Contributor

MajorLift commented Jun 5, 2024

As part of the Wallet Framework Team's Q2 2024 OKRs (O3/KR4), we are upgrading all core packages to use TypeScript v5.1, with the goal of eventually upgrading to the latest version.

Prior to starting the upgrade process, we should read through the v5.1 release announcements and make note of the following in this ticket:

We should also do a trial run of bumping TypeScript versions in core packages and seeing what (if any) error messages we get when we run yarn build and yarn test. These errors should be recorded in this ticket.

@desi
Copy link
Contributor

desi commented Jun 5, 2024

@kanthesha Will you take this one to see what the potential issues might be so we can do refinement on it?

@MajorLift
Copy link
Contributor Author

For the trial run, branch from this PR where the v5.0 upgrade is in place: #3645. If the PR is merged, use the latest version of core.

@kanthesha kanthesha self-assigned this Jun 11, 2024
@kanthesha
Copy link
Contributor

kanthesha commented Jun 13, 2024

I went through what's new in 5.1. And most of the 5.1 improvements are automatically applied (developer experience and optimisation related changes, ). Particularly from 5.1, we can incorporate this new feature Easier Implicit Returns for undefined.

I see that we are also talking about the changes in the earlier versions like satisfies in this ticket. When I looked at the current version, it's 4.9.5! And I also see upgrade to v5.0 in-progress! So bit unclear about what's already covered or what's been left from earlier versions?

@desi
Copy link
Contributor

desi commented Jun 20, 2024

@kanthesha should this be in "needs dev review"? Or "ready for dev"?

@kanthesha
Copy link
Contributor

We can move to "ready to Dev".

@mcmire
Copy link
Contributor

mcmire commented Jun 26, 2024

Should we move this to Blocked since it's dependent on first bumping to TypeScript 5.0?

@kanthesha kanthesha removed their assignment Jul 10, 2024
@MajorLift MajorLift self-assigned this Aug 2, 2024
MajorLift added a commit that referenced this issue Aug 2, 2024
## References

- Closes #4370 

## Changelog

```md
### Changed

- Upgrade TypeScript version to `~5.1.6` ([#4576](#4576))
```

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants