test: Remove undefined from NetworkController "empty values" test cases

Author: rekmarks

packages/network-controller/src/create-network-client.ts

@@ -178,7 +178,7 @@ export function createNetworkClient({
 
   const destroy = () => {
     // TODO: Either fix this lint violation or explain why it's necessary to ignore.
-    // eslint-disable-next-line @typescript-eslint/no-floating-promises
+
     blockTracker.destroy();
   };
 

packages/network-controller/tests/network-client/block-hash-in-response.ts

@@ -203,7 +203,7 @@ export function testsForRpcMethodsThatCheckForBlockHashInResponse(
     });
   });
 
-  for (const emptyValue of [null, undefined, '\u003cnil\u003e']) {
+  for (const emptyValue of [null, '\u003cnil\u003e']) {
     it(`does not retry an empty response of "${emptyValue}"`, async () => {
       const request = { method };
       const mockResult = emptyValue;

packages/network-controller/tests/network-client/block-param.ts

@@ -209,7 +209,7 @@ export function testsForRpcMethodSupportingBlockParam(
       });
     });
 
-    for (const emptyValue of [null, undefined, '\u003cnil\u003e']) {
+    for (const emptyValue of [null, '\u003cnil\u003e']) {
       it(`does not retry an empty response of "${emptyValue}"`, async () => {
         const request = {
           method,
@@ -1227,7 +1227,7 @@ export function testsForRpcMethodSupportingBlockParam(
         });
       });
 
-      for (const emptyValue of [null, undefined, '\u003cnil\u003e']) {
+      for (const emptyValue of [null, '\u003cnil\u003e']) {
         it(`does not retry an empty response of "${emptyValue}"`, async () => {
           const request = {
             method,
@@ -1360,7 +1360,7 @@ export function testsForRpcMethodSupportingBlockParam(
             });
           });
 
-          for (const emptyValue of [null, undefined, '\u003cnil\u003e']) {
+          for (const emptyValue of [null, '\u003cnil\u003e']) {
             if (providerType === 'infura') {
               it(`retries up to 10 times if a "${emptyValue}" response is returned, returning successful non-empty response if there is one on the 10th try`, async () => {
                 const request = {
@@ -1555,7 +1555,7 @@ export function testsForRpcMethodSupportingBlockParam(
           });
         });
 
-        for (const emptyValue of [null, undefined, '\u003cnil\u003e']) {
+        for (const emptyValue of [null, '\u003cnil\u003e']) {
           it(`does not retry an empty response of "${emptyValue}"`, async () => {
             const request = {
               method,

packages/network-controller/tests/network-client/no-block-param.ts

@@ -149,7 +149,7 @@ export function testsForRpcMethodAssumingNoBlockParam(
     });
   });
 
-  for (const emptyValue of [null, undefined, '\u003cnil\u003e']) {
+  for (const emptyValue of [null, '\u003cnil\u003e']) {
     it(`does not retry an empty response of "${emptyValue}"`, async () => {
       const request = { method };
       const mockResult = emptyValue;