Skip to content

Commit ae521de

Browse files
committed
chore(constraints): break loop early; simplify logic
1 parent 4502883 commit ae521de

File tree

1 file changed

+12
-11
lines changed

1 file changed

+12
-11
lines changed

yarn.config.cjs

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -761,23 +761,24 @@ function expectConsistentDependenciesAndDevDependencies(Yarn) {
761761
dependencyIdent,
762762
dependenciesByRange,
763763
] of nonPeerDependenciesByIdent.entries()) {
764+
if (dependenciesByRange.size <= 1) {
765+
continue;
766+
}
764767
const dependenciesToConsider =
765768
getInconsistentDependenciesAndDevDependencies(
766769
dependencyIdent,
767770
dependenciesByRange,
768771
);
769772
const dependencyRanges = [...dependenciesToConsider.keys()].sort();
770-
if (dependenciesByRange.size > 1) {
771-
for (const dependencies of dependenciesToConsider.values()) {
772-
for (const dependency of dependencies) {
773-
dependency.error(
774-
`Expected version range for ${dependencyIdent} (in ${
775-
dependency.type
776-
}) to be consistent across monorepo. Pick one: ${inspect(
777-
dependencyRanges,
778-
)}`,
779-
);
780-
}
773+
for (const dependencies of dependenciesToConsider.values()) {
774+
for (const dependency of dependencies) {
775+
dependency.error(
776+
`Expected version range for ${dependencyIdent} (in ${
777+
dependency.type
778+
}) to be consistent across monorepo. Pick one: ${inspect(
779+
dependencyRanges,
780+
)}`,
781+
);
781782
}
782783
}
783784
}

0 commit comments

Comments
 (0)