feat: skip transaction receipt check if intent complete (#6950)

## Explanation

Do not wait for a transaction receipt if the intent of the transaction
is marked as complete via the new `isIntentComplete` property on
`TransactionMeta`.

## References

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've communicated my changes to consumers by [updating changelogs
for packages I've
changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs),
highlighting breaking changes as necessary
- [x] I've prepared draft pull requests for clients and consumer
packages to resolve any breaking changes

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Introduces `isIntentComplete` on `TransactionMeta` and updates
`PendingTransactionTracker` to mark such transactions confirmed without
fetching a receipt, with corresponding tests and changelog entry.
> 
> - **Types**:
> - Add optional `isIntentComplete` to `TransactionMeta` in
`src/types.ts`.
> - **PendingTransactionTracker**
(`src/helpers/PendingTransactionTracker.ts`):
> - `#checkTransaction` confirms transaction immediately when
`txMeta.isIntentComplete` is true.
> - `#onTransactionConfirmed` now accepts an optional `receipt`; only
fetches block data and sets `baseFeePerGas`, `blockTimestamp`,
`txParams.gasUsed`, `txReceipt`, and `verifiedOnBlockchain` when a
receipt is present.
> - **Tests** (`src/helpers/PendingTransactionTracker.test.ts`):
>   - Add test to assert confirmation when `isIntentComplete` is true.
> - **Changelog**:
> - Document new `isIntentComplete` property and behavior in
`CHANGELOG.md`.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
6741a3b. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Author: matthewwalsh0

packages/transaction-controller/CHANGELOG.md

@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Added
+
+- Add optional `isIntentComplete` property to `TransactionMeta` to indicate transaction outcome was achieved via an alternate chain or mechanism ([#6950](https://github.com/MetaMask/core/pull/6950))
+
 ## [61.0.0]
 
 ### Changed

packages/transaction-controller/src/helpers/PendingTransactionTracker.test.ts

@@ -605,6 +605,41 @@ describe('PendingTransactionTracker', () => {
             }),
           );
         });
+
+        it('if isIntentComplete is true', async () => {
+          const transaction = {
+            ...TRANSACTION_SUBMITTED_MOCK,
+            isIntentComplete: true,
+          };
+
+          const getTransactions = jest
+            .fn()
+            .mockReturnValue(freeze([transaction], true));
+
+          pendingTransactionTracker = new PendingTransactionTracker({
+            ...options,
+            getTransactions,
+          });
+
+          const listener = jest.fn();
+          pendingTransactionTracker.hub.addListener(
+            'transaction-confirmed',
+            listener,
+          );
+
+          await onPoll();
+
+          expect(listener).toHaveBeenCalledTimes(1);
+          expect(listener).toHaveBeenCalledWith(
+            expect.objectContaining({
+              ...TRANSACTION_SUBMITTED_MOCK,
+              txParams: expect.objectContaining(
+                TRANSACTION_SUBMITTED_MOCK.txParams,
+              ),
+              status: TransactionStatus.confirmed,
+            }),
+          );
+        });
       });
 
       describe('fires updated event', () => {

packages/transaction-controller/src/helpers/PendingTransactionTracker.ts

@@ -382,7 +382,12 @@ export class PendingTransactionTracker {
   }
 
   async #checkTransaction(txMeta: TransactionMeta) {
-    const { hash, id } = txMeta;
+    const { hash, id, isIntentComplete } = txMeta;
+
+    if (isIntentComplete) {
+      await this.#onTransactionConfirmed(txMeta);
+      return;
+    }
 
     if (!hash && (await this.#beforeCheckPendingTransaction(txMeta))) {
       const error = new Error(
@@ -450,10 +455,10 @@ export class PendingTransactionTracker {
 
   async #onTransactionConfirmed(
     txMeta: TransactionMeta,
-    receipt: SuccessfulTransactionReceipt,
+    receipt?: SuccessfulTransactionReceipt,
   ) {
     const { id } = txMeta;
-    const { blockHash } = receipt;
+    const { blockHash } = receipt ?? {};
 
     this.#log('Transaction confirmed', id);
 
@@ -463,19 +468,23 @@ export class PendingTransactionTracker {
       return;
     }
 
-    const { baseFeePerGas, timestamp: blockTimestamp } =
-      await this.#getBlockByHash(blockHash, false);
-
     const updatedTxMeta = cloneDeep(txMeta);
-    updatedTxMeta.baseFeePerGas = baseFeePerGas;
-    updatedTxMeta.blockTimestamp = blockTimestamp;
+
+    if (receipt && blockHash) {
+      const { baseFeePerGas, timestamp: blockTimestamp } =
+        await this.#getBlockByHash(blockHash, false);
+
+      updatedTxMeta.baseFeePerGas = baseFeePerGas;
+      updatedTxMeta.blockTimestamp = blockTimestamp;
+      updatedTxMeta.txParams = {
+        ...updatedTxMeta.txParams,
+        gasUsed: receipt.gasUsed,
+      };
+      updatedTxMeta.txReceipt = receipt;
+      updatedTxMeta.verifiedOnBlockchain = true;
+    }
+
     updatedTxMeta.status = TransactionStatus.confirmed;
-    updatedTxMeta.txParams = {
-      ...updatedTxMeta.txParams,
-      gasUsed: receipt.gasUsed,
-    };
-    updatedTxMeta.txReceipt = receipt;
-    updatedTxMeta.verifiedOnBlockchain = true;
 
     this.#updateTransaction(
       updatedTxMeta,

packages/transaction-controller/src/types.ts

@@ -268,6 +268,9 @@ export type TransactionMeta = {
   /** Whether MetaMask will be compensated for the gas fee by the transaction. */
   isGasFeeIncluded?: boolean;
 
+  /** Whether the intent of the transaction was achieved via an alternate route or chain. */
+  isIntentComplete?: boolean;
+
   /**
    * Whether the transaction is an incoming token transfer.
    */