[keyring-controller] Update state in single call when persisting or unlocking (#4154)

## Explanation

`persistAllKeyrings` and `#unlockKeyrings` have been refactored to
update the state in one single call, to avoid side effects to be
executed in the middle of the lock or unlock operations.

`persistAllKeyrings` and `#unlockKeyrings` can now be executed once per
time, since they are both behind the same mutex: this ensures that each
vault read/write operation is executed in a mutually exclusive way

<!--
Thanks for your contribution! Take a moment to answer these questions so
that reviewers have the information they need to properly understand
your changes:

* What is the current state of things and why does it need to change?
* What is the solution your changes offer and how does it work?
* Are there any changes whose purpose might not obvious to those
unfamiliar with the domain?
* If your primary goal was to update one package but you found you had
to update another one along the way, why did you do so?
* If you had to upgrade a dependency, why did you do so?
-->

## References

<!--
Are there any issues that this pull request is tied to? Are there other
links that reviewers should consult to understand these changes better?

For example:

* Fixes #12345
* Related to #67890
-->

N.D.

## Changelog

<!--
If you're making any consumer-facing changes, list those changes here as
if you were updating a changelog, using the template below as a guide.

(CATEGORY is one of BREAKING, ADDED, CHANGED, DEPRECATED, REMOVED, or
FIXED. For security-related issues, follow the Security Advisory
process.)

Please take care to name the exact pieces of the API you've added or
changed (e.g. types, interfaces, functions, or methods).

If there are any breaking changes, make sure to offer a solution for
consumers to follow once they upgrade to the changes.

Finally, if you're only making changes to development scripts or tests,
you may replace the template below with "None".
-->

### `@metamask/keyring-controller`

- **FIXED**: State updates are executed in a single call when locking or
unlocking the `KeyringController`.

## Checklist

- [ ] I've updated the test suite for new or updated code as appropriate
- [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [ ] I've highlighted breaking changes using the "BREAKING" category
above as appropriate

Author: mikesposito

packages/keyring-controller/jest.config.js

@@ -19,8 +19,8 @@ module.exports = merge(baseConfig, {
     global: {
       branches: 95.65,
       functions: 100,
-      lines: 99.17,
-      statements: 99.18,
+      lines: 98.99,
+      statements: 99,
     },
   },
 

packages/keyring-controller/src/KeyringController.test.ts

@@ -3143,6 +3143,36 @@ describe('KeyringController', () => {
       });
     });
   });
+
+  describe('run conditions', () => {
+    describe('submitPassword', () => {
+      it('should not cause run conditions when called multiple times', async () => {
+        await withController(async ({ controller, initialState }) => {
+          await Promise.all([
+            controller.submitPassword(password),
+            controller.submitPassword(password),
+            controller.submitPassword(password),
+            controller.submitPassword(password),
+          ]);
+
+          expect(controller.state).toStrictEqual(initialState);
+        });
+      });
+
+      it('should not cause run conditions when called multiple times in combination with persistAllKeyrings', async () => {
+        await withController(async ({ controller, initialState }) => {
+          await Promise.all([
+            controller.submitPassword(password),
+            controller.persistAllKeyrings(),
+            controller.submitPassword(password),
+            controller.persistAllKeyrings(),
+          ]);
+
+          expect(controller.state).toStrictEqual(initialState);
+        });
+      });
+    });
+  });
 });
 
 type WithControllerCallback<ReturnValue> = ({