cmd/geth: parse uint64 value with ParseUint instead of Atoi (ethereum#25545)

jtraglia · HanWang233 · commit 1f1250259052 · 2022-09-11T16:48:47.000+08:00
Parse uint64 value with ParseUint instead of Atoi
diff --git a/cmd/geth/chaincmd.go b/cmd/geth/chaincmd.go
@@ -384,12 +384,12 @@ func parseDumpConfig(ctx *cli.Context, stack *node.Node) (*state.DumpConfig, eth
 				return nil, nil, common.Hash{}, fmt.Errorf("block %x not found", hash)
 			}
 		} else {
-			number, err := strconv.Atoi(arg)
+			number, err := strconv.ParseUint(arg, 10, 64)
 			if err != nil {
 				return nil, nil, common.Hash{}, err
 			}
-			if hash := rawdb.ReadCanonicalHash(db, uint64(number)); hash != (common.Hash{}) {
-				header = rawdb.ReadHeader(db, hash, uint64(number))
+			if hash := rawdb.ReadCanonicalHash(db, number); hash != (common.Hash{}) {
+				header = rawdb.ReadHeader(db, hash, number)
 			} else {
 				return nil, nil, common.Hash{}, fmt.Errorf("header for block %d not found", number)
 			}

Original file line number	Diff line number	Diff line change
`@@ -384,12 +384,12 @@ func parseDumpConfig(ctx cli.Context, stack node.Node) (*state.DumpConfig, eth`
`384`	`384`	`return nil, nil, common.Hash{}, fmt.Errorf("block %x not found", hash)`
`385`	`385`	`}`
`386`	`386`	`} else {`
`387`		`- number, err := strconv.Atoi(arg)`
	`387`	`+ number, err := strconv.ParseUint(arg, 10, 64)`
`388`	`388`	`if err != nil {`
`389`	`389`	`return nil, nil, common.Hash{}, err`
`390`	`390`	`}`
`391`		`- if hash := rawdb.ReadCanonicalHash(db, uint64(number)); hash != (common.Hash{}) {`
`392`		`- header = rawdb.ReadHeader(db, hash, uint64(number))`
	`391`	`+ if hash := rawdb.ReadCanonicalHash(db, number); hash != (common.Hash{}) {`
	`392`	`+ header = rawdb.ReadHeader(db, hash, number)`
`393`	`393`	`} else {`
`394`	`394`	`return nil, nil, common.Hash{}, fmt.Errorf("header for block %d not found", number)`
`395`	`395`	`}`