Improve display_generating fix for OpenAI non-streaming mode

- Add missing display_fn support to async version (achat_completion_with_tools)
- Add proper error handling with try-catch around Live context manager
- Add safer content access with length checks for choices array
- Add console cleanup (console.print()) consistent with streaming mode
- Maintain backward compatibility with fallback to regular completion

Co-authored-by: Mervin Praison <MervinPraison@users.noreply.github.com>

Author: github-actions[bot]

src/praisonai-agents/praisonaiagents/llm/openai_client.py

@@ -840,7 +840,26 @@ def chat_completion_with_tools(
                 # Process as regular non-streaming response
                 if display_fn and console:
                     # Show display_generating animation for non-streaming mode when display_fn is provided
-                    with Live(display_fn("", start_time), console=console, refresh_per_second=4) as live:
+                    try:
+                        with Live(display_fn("", start_time), console=console, refresh_per_second=4) as live:
+                            final_response = self.create_completion(
+                                messages=messages,
+                                model=model,
+                                temperature=temperature,
+                                tools=formatted_tools,
+                                stream=False,
+                                **kwargs
+                            )
+                            # Update display with final content if available
+                            if final_response and final_response.choices and len(final_response.choices) > 0:
+                                content = final_response.choices[0].message.content or ""
+                                live.update(display_fn(content, start_time))
+                        
+                        # Clear the last generating display with a blank line
+                        console.print()
+                    except Exception as e:
+                        self.logger.error(f"Error in Live display for non-streaming: {e}")
+                        # Fallback to regular completion without display
                         final_response = self.create_completion(
                             messages=messages,
                             model=model,
@@ -849,10 +868,6 @@ def chat_completion_with_tools(
                             stream=False,
                             **kwargs
                         )
-                        # Update display with empty content as we don't have streaming chunks
-                        if final_response and final_response.choices:
-                            content = final_response.choices[0].message.content or ""
-                            live.update(display_fn(content, start_time))
                 else:
                     final_response = self.create_completion(
                         messages=messages,
@@ -985,14 +1000,45 @@ async def achat_completion_with_tools(
                 )
             else:
                 # Process as regular non-streaming response
-                final_response = await self.acreate_completion(
-                    messages=messages,
-                    model=model,
-                    temperature=temperature,
-                    tools=formatted_tools,
-                    stream=False,
-                    **kwargs
-                )
+                if display_fn and console:
+                    # Show display_generating animation for non-streaming mode when display_fn is provided
+                    try:
+                        with Live(display_fn("", start_time), console=console, refresh_per_second=4) as live:
+                            final_response = await self.acreate_completion(
+                                messages=messages,
+                                model=model,
+                                temperature=temperature,
+                                tools=formatted_tools,
+                                stream=False,
+                                **kwargs
+                            )
+                            # Update display with final content if available
+                            if final_response and final_response.choices and len(final_response.choices) > 0:
+                                content = final_response.choices[0].message.content or ""
+                                live.update(display_fn(content, start_time))
+                        
+                        # Clear the last generating display with a blank line
+                        console.print()
+                    except Exception as e:
+                        self.logger.error(f"Error in Live display for async non-streaming: {e}")
+                        # Fallback to regular completion without display
+                        final_response = await self.acreate_completion(
+                            messages=messages,
+                            model=model,
+                            temperature=temperature,
+                            tools=formatted_tools,
+                            stream=False,
+                            **kwargs
+                        )
+                else:
+                    final_response = await self.acreate_completion(
+                        messages=messages,
+                        model=model,
+                        temperature=temperature,
+                        tools=formatted_tools,
+                        stream=False,
+                        **kwargs
+                    )
 
             if not final_response:
                 return None