refactor: improve telemetry shutdown error handling and reduce code duplication

- Add centralized _SHUTDOWN_ERROR_PHRASES constant for consistent error detection
- Create _is_shutdown_related_error() helper method to eliminate code duplication
- Remove duplicate import threading in _is_interpreter_shutting_down()
- Remove redundant _posthog = None assignment handled by finally block
- Ensure all shutdown error detection uses consistent phrase list

Addresses reviewer feedback on duplicate imports, inconsistent error handling,
and code duplication while maintaining full backward compatibility.

Co-authored-by: Mervin Praison <MervinPraison@users.noreply.github.com>

Author: github-actions[bot]

src/praisonai-agents/praisonaiagents/telemetry/telemetry.py

@@ -41,6 +41,15 @@ class MinimalTelemetry:
     - Can be disabled via environment variables
     """
 
+    # Common error phrases that indicate interpreter shutdown
+    _SHUTDOWN_ERROR_PHRASES = [
+        'cannot schedule new futures',
+        'interpreter shutdown',
+        'atexit after shutdown',
+        'event loop closed',
+        'runtime is shutting down'
+    ]
+    
     def __init__(self, enabled: bool = None):
         """
         Initialize the minimal telemetry collector.
@@ -350,7 +359,6 @@ def shutdown(self):
                 # Check if Python interpreter is shutting down
                 if self._is_interpreter_shutting_down():
                     self.logger.debug("Interpreter shutting down, skipping PostHog operations")
-                    self._posthog = None
                     return
 
                 # Use a timeout-based flush to prevent hanging
@@ -382,20 +390,26 @@ def shutdown(self):
 
             except Exception as e:
                 # Handle specific shutdown-related errors gracefully
-                error_msg = str(e).lower()
-                if any(phrase in error_msg for phrase in [
-                    'cannot schedule new futures',
-                    'interpreter shutdown',
-                    'atexit after shutdown',
-                    'event loop closed',
-                    'runtime is shutting down'
-                ]):
+                if self._is_shutdown_related_error(e):
                     self.logger.debug(f"PostHog shutdown prevented due to interpreter shutdown: {e}")
                 else:
                     self.logger.error(f"Error during PostHog shutdown: {e}")
             finally:
                 self._posthog = None
 
+    def _is_shutdown_related_error(self, error: Exception) -> bool:
+        """
+        Check if an error is related to interpreter shutdown.
+        
+        Args:
+            error: The exception to check
+            
+        Returns:
+            True if the error is shutdown-related, False otherwise
+        """
+        error_msg = str(error).lower()
+        return any(phrase in error_msg for phrase in self._SHUTDOWN_ERROR_PHRASES)
+    
     def _is_interpreter_shutting_down(self) -> bool:
         """
         Check if the Python interpreter is shutting down.
@@ -413,7 +427,6 @@ def _is_interpreter_shutting_down(self) -> bool:
 
             # Check if we can create new threads (fails during shutdown)
             try:
-                import threading
                 test_thread = threading.Thread(target=lambda: None)
                 test_thread.daemon = True
                 test_thread.start()
@@ -437,14 +450,7 @@ def _safe_flush_posthog(self, posthog_client):
             posthog_client.flush()
             return True
         except Exception as e:
-            error_msg = str(e).lower()
-            if any(phrase in error_msg for phrase in [
-                'cannot schedule new futures',
-                'interpreter shutdown',
-                'atexit after shutdown',
-                'event loop closed',
-                'runtime is shutting down'
-            ]):
+            if self._is_shutdown_related_error(e):
                 self.logger.debug(f"PostHog flush prevented due to interpreter shutdown: {e}")
             else:
                 self.logger.debug(f"PostHog flush error: {e}")
@@ -469,13 +475,7 @@ def _shutdown_posthog_threads(self, posthog_client):
                         import time
                         time.sleep(0.5)
                 except Exception as e:
-                    error_msg = str(e).lower()
-                    if any(phrase in error_msg for phrase in [
-                        'cannot schedule new futures',
-                        'interpreter shutdown',
-                        'atexit after shutdown',
-                        'event loop closed'
-                    ]):
+                    if self._is_shutdown_related_error(e):
                         self.logger.debug(f"Thread pool shutdown prevented due to interpreter shutdown: {e}")
                     else:
                         self.logger.debug(f"Thread pool shutdown error: {e}")
@@ -489,25 +489,13 @@ def _shutdown_posthog_threads(self, posthog_client):
                     if hasattr(consumer, 'shutdown'):
                         consumer.shutdown()
                 except Exception as e:
-                    error_msg = str(e).lower()
-                    if any(phrase in error_msg for phrase in [
-                        'cannot schedule new futures',
-                        'interpreter shutdown',
-                        'atexit after shutdown',
-                        'event loop closed'
-                    ]):
+                    if self._is_shutdown_related_error(e):
                         self.logger.debug(f"Consumer shutdown prevented due to interpreter shutdown: {e}")
                     else:
                         self.logger.debug(f"Consumer shutdown error: {e}")
 
         except Exception as e:
-            error_msg = str(e).lower()
-            if any(phrase in error_msg for phrase in [
-                'cannot schedule new futures',
-                'interpreter shutdown',
-                'atexit after shutdown',
-                'event loop closed'
-            ]):
+            if self._is_shutdown_related_error(e):
                 self.logger.debug(f"PostHog thread cleanup prevented due to interpreter shutdown: {e}")
             else:
                 self.logger.debug(f"Error during PostHog thread cleanup: {e}")