fix: resolve MongoDB integration issues

- Fix ID generation consistency between MongoDB and SQLite storage
- Fix inconsistent error handling in memory operations
- Fix security issue with hardcoded API key placeholders in examples
- Fix unused imports in mongodb_tools.py
- Fix pymongo version to >= 4.6.3 to address security vulnerabilities
- Improve datetime import organization
- Ensure consistent storage order for better reliability

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-authored-by: Mervin Praison <MervinPraison@users.noreply.github.com>

Author: github-actions[bot]

examples/python/mongodb/mongodb_comprehensive_example.py

@@ -23,8 +23,9 @@
 from praisonaiagents import Agent, Task, PraisonAIAgents
 from praisonaiagents.tools import mongodb_tools
 
-# Set up environment variables
-os.environ["OPENAI_API_KEY"] = "your-openai-api-key"  # Replace with your actual API key
+# Ensure OpenAI API key is set
+if not os.environ.get("OPENAI_API_KEY"):
+    raise ValueError("Please set the OPENAI_API_KEY environment variable")
 
 def main():
     # MongoDB configuration for different components

examples/python/mongodb/mongodb_knowledge_example.py

@@ -21,8 +21,9 @@
 import os
 from praisonaiagents import Agent, Task, PraisonAIAgents
 
-# Set up environment variables
-os.environ["OPENAI_API_KEY"] = "your-openai-api-key"  # Replace with your actual API key
+# Ensure OpenAI API key is set
+if not os.environ.get("OPENAI_API_KEY"):
+    raise ValueError("Please set the OPENAI_API_KEY environment variable")
 
 def main():
     # MongoDB knowledge configuration

examples/python/mongodb/mongodb_memory_example.py

@@ -21,8 +21,9 @@
 import os
 from praisonaiagents import Agent, Task, PraisonAIAgents
 
-# Set up environment variables
-os.environ["OPENAI_API_KEY"] = "your-openai-api-key"  # Replace with your actual API key
+# Ensure OpenAI API key is set
+if not os.environ.get("OPENAI_API_KEY"):
+    raise ValueError("Please set the OPENAI_API_KEY environment variable")
 
 def main():
     # MongoDB memory configuration

examples/python/mongodb/mongodb_tools_example.py

@@ -22,8 +22,9 @@
 from praisonaiagents import Agent, Task, PraisonAIAgents
 from praisonaiagents.tools import mongodb_tools
 
-# Set up environment variables
-os.environ["OPENAI_API_KEY"] = "your-openai-api-key"  # Replace with your actual API key
+# Ensure OpenAI API key is set
+if not os.environ.get("OPENAI_API_KEY"):
+    raise ValueError("Please set the OPENAI_API_KEY environment variable")
 
 def main():
     # Create a MongoDB Database Agent with MongoDB tools

src/praisonai-agents/praisonaiagents/memory/memory.py

@@ -5,6 +5,7 @@
 import shutil
 from typing import Any, Dict, List, Optional, Union, Literal
 import logging
+from datetime import datetime
 
 # Disable litellm telemetry before any imports
 os.environ["LITELLM_TELEMETRY"] = "False"
@@ -483,11 +484,13 @@ def store_short_term(
         )
         logger.info(f"Processed metadata: {metadata}")
 
+        # Generate unique ID and timestamp once
+        ident = str(time.time_ns())
+        created_at = time.time()
+        
         # Store in MongoDB if enabled
         if self.use_mongodb and hasattr(self, "mongo_short_term"):
             try:
-                from datetime import datetime
-                ident = str(time.time_ns())
                 doc = {
                     "_id": ident,
                     "content": text,
@@ -504,10 +507,9 @@ def store_short_term(
         # Existing SQLite store logic
         try:
             conn = sqlite3.connect(self.short_db)
-            ident = str(time.time_ns())
             conn.execute(
                 "INSERT INTO short_mem (id, content, meta, created_at) VALUES (?,?,?,?)",
-                (ident, text, json.dumps(metadata), time.time())
+                (ident, text, json.dumps(metadata), created_at)
             )
             conn.commit()
             conn.close()
@@ -721,25 +723,9 @@ def store_long_term(
         ident = str(time.time_ns())
         created = time.time()
 
-        # Store in SQLite
-        try:
-            conn = sqlite3.connect(self.long_db)
-            conn.execute(
-                "INSERT INTO long_mem (id, content, meta, created_at) VALUES (?,?,?,?)",
-                (ident, text, json.dumps(metadata), created)
-            )
-            conn.commit()
-            conn.close()
-            logger.info(f"Successfully stored in SQLite with ID: {ident}")
-        except Exception as e:
-            logger.error(f"Error storing in SQLite: {e}")
-            return
-
-        # Store in MongoDB if enabled
+        # Store in MongoDB if enabled (first priority)
         if self.use_mongodb and hasattr(self, "mongo_long_term"):
             try:
-                from datetime import datetime
-                ident = str(time.time_ns())
                 doc = {
                     "_id": ident,
                     "content": text,
@@ -758,8 +744,23 @@ def store_long_term(
                 logger.info(f"Successfully stored in MongoDB long-term memory with ID: {ident}")
             except Exception as e:
                 logger.error(f"Failed to store in MongoDB long-term memory: {e}")
-                if not self.use_rag:  # Only raise if no fallback available
-                    return
+                # Continue to SQLite fallback
+        
+        # Store in SQLite
+        try:
+            conn = sqlite3.connect(self.long_db)
+            conn.execute(
+                "INSERT INTO long_mem (id, content, meta, created_at) VALUES (?,?,?,?)",
+                (ident, text, json.dumps(metadata), created)
+            )
+            conn.commit()
+            conn.close()
+            logger.info(f"Successfully stored in SQLite with ID: {ident}")
+        except Exception as e:
+            logger.error(f"Error storing in SQLite: {e}")
+            if not (self.use_mongodb and hasattr(self, "mongo_long_term")):
+                # Only raise if MongoDB is not available as fallback
+                return
 
         # Store in vector database if enabled
         if self.use_rag and hasattr(self, "chroma_col"):

src/praisonai-agents/praisonaiagents/tools/mongodb_tools.py

@@ -13,8 +13,6 @@
 import logging
 from typing import List, Dict, Any, Optional, Union, TYPE_CHECKING
 from importlib import util
-import json
-import time
 from datetime import datetime
 
 if TYPE_CHECKING:

src/praisonai-agents/pyproject.toml

@@ -62,7 +62,7 @@ telemetry = [
 
 # MongoDB dependencies
 mongodb = [
-    "pymongo>=4.6.0",
+    "pymongo>=4.6.3",
     "motor>=3.4.0"
 ]