V2 endpoints for user and access management #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varmar05
requested changes
Feb 14, 2025
- add project and workspace role enums - add optional username to create_user - remove redudant arguments from delete() method - add tests for failures - permission issue, duplicate call, editor limit hit
MarcelGeo
reviewed
Feb 17, 2025
There was a problem hiding this comment.
Nice..
-
one suggest for methods
add_user_permissions_to_project,remove_user_permissions_from_project- we can add there message that this function will be deprecated in next major release 1.0.0 ? -
could we use new introduced methods also in tests e.g for
test_editor_pushand similar?
MarcelGeo
approved these changes
Feb 19, 2025
varmar05
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #227
Implement v2 endpoints for creating user and CRUD on workspace and project roles.