Do not use paginated versions endpoint #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- CLI: update show version command to call project_version_info object - CLIENT: upgrade project_version_info api call to use get byt version name endpoint instead of paginated version - TEST: don't use paginated endpoint in tests - TEST: make tests runnable with other username, than test_plugin Minor: - add year to copyright :)
Pull Request Test Coverage Report for Build 10716697553Details
💛 - Coveralls |
varmar05
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #214
Changes:
Fix 🐛
Detail: Wrong type, expected 'integer' for query parameter 'page'- show-version was not running properly.Minor:
Related to: https://github.com/MerginMaps/server/pull/275/files