-
Notifications
You must be signed in to change notification settings - Fork 75
Better paths sanitization #4229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tomasMizera
wants to merge
5
commits into
master
Choose a base branch
from
fix/better-paths-sanitization
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 19640387302Details
💛 - Coveralls |
Withalion
reviewed
Nov 23, 2025
Contributor
Withalion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor improvements
Withalion
approved these changes
Nov 24, 2025
Collaborator
Author
|
Hi @RastoHu @IvaKuklica, here are the builds to test: 🍎 iOS: 25.11.828011 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some enhancements to the sanitization logic:
/ my folder / my file.ext~>/my folder/my file.ext/my folder/my file .ext~>/my folder/my file.extThese scenarios were possible because of the custom photo name formats. It then caused problems when syncing to desktop builds or server did not allows such an upload at all.
These two enhancements are used in:
projectwizard.cpp-> sanitize project name so it does not include a whitespace at the endattributecontroller.cpp-> when renaming photosFixes #3976
Fixes #4022
Fixes (likely) #4157 - needs to be tested (cc @RastoHu @IvaKuklica)
See also MerginMaps/qgis-plugin#693
Qt handles path separators automatically, but would be good to test this out on Windows, just to be sure.