scrollbar for desktop builds in feature lists #4145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 19935992820Details
💛 - Coveralls |
Withalion
reviewed
Oct 11, 2025
Withalion
force-pushed
the
dev/2025.8.0
branch
from
75c3747 to
eb72e98
Compare
Withalion
reviewed
Oct 22, 2025
Contributor
Withalion
left a comment
Withalion
left a comment
There was a problem hiding this comment.
On second thought, it would make more sense to move the scrollbar directly into MMListView and/or MMScrollView as we want the scrollbar for all lists in the app as mentioned in #4127 . Right now it would be just for feature list.
tomasMizera
requested changes
Oct 28, 2025
gabriel-bolbotina
force-pushed
the
fix/featurelistScrollbar
branch
from
031f38d to
d90b2c1
Compare
Added property to make the scroll bar disappear where is not needed
Withalion
reviewed
Nov 27, 2025
Contributor
Withalion
left a comment
Withalion
left a comment
There was a problem hiding this comment.
I have mixed feelings about these changes. 2 things I don't like:
- when we are defining delegates we should not care if the
Viewhas scroll bar or not.FlickableshavecontentWidthproperty, but we don't utilize it. I'm not sure if it should be calculated automatically or by us. - we show the scroll bars even though they are not necessary. We should never show them on mobile, show them when necessary on desktop and they should not hide.
app/qml/components/MMListView.qml
Outdated
Comment on lines
23
to
25
| readonly property bool isMobile: (Qt.platform.os === "android" || Qt.platform.os === "ios") | ||
| property int scrollSpace: !isMobile ? 10 : 0 | ||
| property bool showScrollBar: true |
Contributor
There was a problem hiding this comment.
isMobilecould be just internal propertyscrollSpaceI would rename it to something more meaningful likescrollBarWidthand it should be read only, and maybe we should use__style.margin10showScrollBarI would change it to alias referingverticalScrollBar.policyand get rid ofvisibleproperty
Contributor
There was a problem hiding this comment.
How should I make isMobile an internal property?
Contributor
There was a problem hiding this comment.
With QtObject component as we do in other places
Made it visible in every situation
Withalion
approved these changes
Dec 5, 2025
Contributor
Withalion
left a comment
Withalion
left a comment
There was a problem hiding this comment.
Some stuff doesn't look the best, but it would probably require a bigger refactor, which is out of scope of this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Case: Missing scrollbar for the desktop version for all the ListView components.
What has be been done:
Added slim scrollbar on the right side of the lists.
Scroll bar only activates for desktops; ex(macos, window, linux) and not any mobile builds
Scrollbar always visibile, but highlights on active more and passive on inactive.
Tested for mutiple page which uses ListView and the work of scrollbar
Screen.Recording.2025-10-23.at.12.18.39.PM.mov