Refactor daemon with memory-safe loop and logging #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterPetrik
reviewed
Jun 12, 2025
Collaborator
|
@varmar05 To me this looks ok. I should not be really necessary to manually call the The logging seems to impove with this as well. |
varmar05
requested changes
Nov 11, 2025
| logger.info("Sync complete.") | ||
|
|
||
| # Force garbage collection | ||
| gc.collect() |
Contributor
There was a problem hiding this comment.
Do we know what was the issue with memory (maybe we could fix the source of the issue)? As gc should be automatic we should probably know why to force it.
| sys.exit(1) | ||
|
|
||
| print("Logging in to Mergin...") | ||
| logger.info("Logging in to Mergin...") |
Contributor
There was a problem hiding this comment.
I suggest to update Mergin... to Mergin Maps server ... in all occurrences for better clarity
| if delta.total_seconds() < 3600: | ||
| logger.info("Refreshing Mergin auth token...") | ||
| mc = create_mergin_client() | ||
| except Exception as e: |
Contributor
There was a problem hiding this comment.
This seems to me too broad, can you narrow it down to MerginClient error or something similar?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors media_sync_daemon.py to eliminate unbounded memory growth by rewriting the main loop.
Tested on Lightsail t3.nano with persistent background sync.
Note: Block I/O still increasing unchecked.