Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 25, 2025

Description

Updates Microsoft.Build.Locator from 1.10.12 to 1.11.1. This version adds buildTransitive validation that requires all MSBuild-related packages to have ExcludeAssets="runtime" set.

Added explicit package references with ExcludeAssets="runtime" to LoggerUsage.VSCode.Bridge.csproj because the attribute doesn't propagate transitively through project references:

  • Microsoft.Build
  • Microsoft.Build.Framework
  • Microsoft.Build.Tasks.Core
  • Microsoft.Build.Utilities.Core
  • Microsoft.NET.StringTools

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test coverage improvement
  • CI/CD pipeline update

Checklist

  • My code follows the project's coding guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

For VS Code Extension Changes

N/A

For .NET Library Changes

  • Solution builds without errors (dotnet build)
  • All tests pass (dotnet test)
  • Code coverage is maintained or improved
  • XML documentation added for public APIs
  • Followed Roslyn API best practices
  • Updated copilot-instructions.md if architecture changed

Testing

Test Environment

  • .NET SDK Version: 10.0

Test Cases

  1. dotnet build src/LoggerUsage.VSCode.Bridge/LoggerUsage.VSCode.Bridge.csproj succeeds
  2. dotnet build (full solution) succeeds

Screenshots (if applicable)

N/A

Related Issues

Fixes MSBL001 build error introduced by Microsoft.Build.Locator 1.11.1

Additional Context

The MSBL001 error occurs because MSBuild.Locator 1.11.1 validates that consuming projects don't include MSBuild runtime assemblies, which would conflict with the dynamically-loaded MSBuild instance.

Breaking Changes

None

Reviewer Notes

Package versions are managed centrally in Directory.Packages.props.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…ges in VSCode.Bridge

Co-authored-by: Meir017 <9786571+Meir017@users.noreply.github.com>
Copilot AI changed the title [WIP] Update Microsoft.Build.Locator from 1.10.12 to 1.11.1 Bump Microsoft.Build.Locator from 1.10.12 to 1.11.1 Nov 25, 2025
Copilot AI requested a review from Meir017 November 25, 2025 05:06
Copilot finished work on behalf of Meir017 November 25, 2025 05:06
@Meir017 Meir017 marked this pull request as ready for review November 25, 2025 05:52
@Meir017 Meir017 merged commit 201d780 into dependabot/nuget/Microsoft.Build.Locator-1.11.1 Nov 25, 2025
@Meir017 Meir017 deleted the copilot/sub-pr-155 branch November 25, 2025 05:52
Meir017 added a commit that referenced this pull request Nov 25, 2025
* Bump Microsoft.Build.Locator from 1.10.12 to 1.11.1

---
updated-dependencies:
- dependency-name: Microsoft.Build.Locator
  dependency-version: 1.11.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump Microsoft.Build.Locator from 1.10.12 to 1.11.1 (#159)

* Initial plan

* Fix build errors with Microsoft.Build.Locator 1.11.1 by excluding runtime assets

Co-authored-by: Meir017 <9786571+Meir017@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Meir017 <9786571+Meir017@users.noreply.github.com>

* Bump Microsoft.Build.Locator from 1.10.12 to 1.11.1 (#160)

* Initial plan

* Fix MSBL001 build error: Add ExcludeAssets="runtime" to MSBuild packages in VSCode.Bridge

Co-authored-by: Meir017 <9786571+Meir017@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Meir017 <9786571+Meir017@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Meir017 <9786571+Meir017@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants