Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renderRoot Readability of do-while loop #5

Open
2 tasks
CMenne opened this issue Dec 2, 2018 · 0 comments
Open
2 tasks

renderRoot Readability of do-while loop #5

CMenne opened this issue Dec 2, 2018 · 0 comments
Assignees

Comments

@CMenne
Copy link
Member

CMenne commented Dec 2, 2018

Do-While Loops

1. Do-while loop with a true conditional isn’t very readable.

2. A do-while loop with a break at the end isn’t indicative of the purpose of the do-while loop

Lines:
  • 1298
What we intend to do:
  • Change the while conditional so it better describes the purpose of the loop

3. Nested conditionals can be extracted into their own function.

Lines:
  • 1242
  • 1263
What we intend to do:
  • Extract interior into its own function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants