Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to get stories by folder per store view #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rossmc
Copy link

@rossmc rossmc commented Nov 25, 2021

Adds a new Sys Config option for the top level folder in-which Storyblok stories are contained.

Screenshot 2021-11-25 at 16 46 01

May be used for:

Screenshot 2021-11-25 at 16 50 00

Adds a new Sys Config option for the top level folder in-which Storyblok
stories are contained.

May be used for:
- multi-language Magento installs to for folder-level.
https://www.storyblok.com/docs/guide/in-depth/internationalization#folder-level-translation
- multi website / store view Magento installs to manage all stories from
one space.
@rossmc
Copy link
Author

rossmc commented Dec 16, 2021

Hi @jahvi, interested in your feedback on this when you get a chance

@mzeis
Copy link

mzeis commented Apr 25, 2022

Hi @rossmc, thank you for providing this PR. I like it a lot!

Did you end up using this in production?

@rossmc
Copy link
Author

rossmc commented Apr 25, 2022

Hi @mzeis,

Yes, it's been working fine on one of our production sites for a a few months now without any issue :)

You can install this PR as a patch if you like:
https://patch-diff.githubusercontent.com/raw/Media-Lounge/magento2-storyblok-integration/pull/27.patch

Let me know how it goes.

@mzeis
Copy link

mzeis commented Apr 26, 2022

Hi @rossmc,
thanks a lot for your response, that's great to read! Will do.

We might also look into creating alternate hreflang tags based on the Dimensions App. Is this something that could be useful to you?

@rossmc
Copy link
Author

rossmc commented Apr 26, 2022

Hi @mzeis ,

I hadn't considered hreflang tags based on the Dimensions App, it would indeed be useful. Thanks :)

@mzeis
Copy link

mzeis commented May 4, 2022

Hi @rossmc,
just wanted to let you know that we tested your PR and it's working great for us. Thanks again for sharing!

I'll let you know if we have any updates regarding hreflang tags.

@rossmc
Copy link
Author

rossmc commented May 6, 2022

nice to hear, thanks @mzeis :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants