Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pickle Bugfix #392

Merged
merged 4 commits into from
Feb 27, 2024
Merged

Pickle Bugfix #392

merged 4 commits into from
Feb 27, 2024

Conversation

mparno
Copy link
Contributor

@mparno mparno commented Feb 27, 2024

  • Fixed a bug in the serialization of the pytorch wrapper using dill or pickle. The bug manifested in the following warning:
PicklingWarning: Cannot pickle <class 'mpart.torch.MpartTorchAutograd'>: mpart.torch.MpartTorchAutograd has recursive self-references that trigger a RecursionError.
  • Updated workflows and dependencies to support new release branch.

@mparno mparno requested a review from dannys4 February 27, 2024 14:18
Copy link

github-actions bot commented Feb 27, 2024

Test Results with Bindings

66 tests  +1   66 ✅ +1   43s ⏱️ +20s
 2 suites ±0    0 💤 ±0 
 2 files   ±0    0 ❌ ±0 

Results for commit c93aa58. ± Comparison against base commit fd3ebeb.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 27, 2024

Test Results with Externally Built Libraries

     1 files  ±0       1 suites  ±0   6s ⏱️ ±0s
   276 tests ±0     276 ✅ ±0  0 💤 ±0  0 ❌ ±0 
36 000 runs  ±0  36 000 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit c93aa58. ± Comparison against base commit fd3ebeb.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 27, 2024

Test Results

         1 files  ±0           1 suites  ±0   6s ⏱️ ±0s
     276 tests ±0       276 ✔️ ±0  0 💤 ±0  0 ±0 
36 000 runs  ±0  36 000 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit c93aa58. ± Comparison against base commit fd3ebeb.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@dannys4 dannys4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mparno mparno merged commit 6e84606 into release Feb 27, 2024
10 checks passed
@mparno mparno deleted the torch-pickle branch February 27, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants