Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on creating Triangular Map in MATLAB [v. 2.2.0] #360

Closed
jgrashorn opened this issue Nov 14, 2023 · 3 comments · Fixed by #361
Closed

Error on creating Triangular Map in MATLAB [v. 2.2.0] #360

jgrashorn opened this issue Nov 14, 2023 · 3 comments · Fixed by #361
Labels
bindings Specific to MParT bindings (python, julia, matlab) bug Something isn't working
Milestone

Comments

@jgrashorn
Copy link

Hey!
I just upgraded to version 2.2.0 of MParT and on calling the CreateTriangular()-function I get the following error. Reverting back to version 2.1.0 and using the same code produces no error.
I'm using MATLAB 2023b on Ubuntu.

Error using MParT_
Id is empty.

Error in ConditionalMap/delete (line 92)
    MParT_('ConditionalMap_deleteMap', this.id_);

Error in ConditionalMap (line 26)
    if(nargin==2)

Error in CreateTriangular (line 2)
    map = ConditionalMap(inDim, outDim, order, opts);

Error in Duffing (line 145)
            map{i}(mapIdx) = CreateTriangular(dataSize+mapIdx,1,mapOrder,opts); 
> In ConditionalMap (line 26)
In CreateTriangular (line 2)
In Duffing (line 145) 
Error using MParT_
Option name must be char but is given double.

Error in ConditionalMap (line 81)
      this.id_ = eval(input_str);

Error in CreateTriangular (line 2)
    map = ConditionalMap(inDim, outDim, order, opts);
@dannys4 dannys4 added bug Something isn't working bindings Specific to MParT bindings (python, julia, matlab) labels Nov 14, 2023
@dannys4
Copy link
Contributor

dannys4 commented Nov 14, 2023

I can replicate this with a simple

opts = MapOptions();
trimap = CreateTriangular(2,2,3,opts);

(the 2,2,3 are entirely arbitrary). It could be an issue with a recent change; e.g., #353 or honestly even #310.

I'll look into it!

EDIT: Scratch that, it's definitely an issue from #353 if 2.1.0 works. I'll look into what needs to get changed.

@dannys4
Copy link
Contributor

dannys4 commented Nov 15, 2023

When you get a chance, bump to the latest commit I just put out on main and see if your issue is resolved. The tests run on my end, but I'm not sure about you.

@jgrashorn
Copy link
Author

It works on my end as well, thanks so much!

@dannys4 dannys4 added this to the v3 milestone Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bindings Specific to MParT bindings (python, julia, matlab) bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants