Skip to content

Commit f777b12

Browse files
committed
fix(web): remove unused selectFields prop from EntityDetailLayout calls
Removes selectFields prop from 12 entity route files where it was being passed to EntityDetailLayout component. This prop was removed from the EntityDetailLayoutProps interface in commit 090e0d6 but the callsites were not updated, causing TypeScript errors in CI. Changes: - Removed selectFields prop from all entity detail route components - Routes affected: authors, concepts, domains, fields, funders, institutions, keywords, publishers, sources, subfields, topics, works Resolves CI typecheck failures.
1 parent d20256b commit f777b12

File tree

12 files changed

+0
-12
lines changed

12 files changed

+0
-12
lines changed

apps/web/src/routes/authors/$_.lazy.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,6 @@ const AuthorRoute = () => {
9090
entityId={decodedAuthorId}
9191
displayName={author.display_name || "Author"}
9292
selectParam={(selectParam as string) || ''}
93-
selectFields={selectFields || []}
9493
viewMode={viewMode}
9594
onViewModeChange={setViewMode}
9695
data={author as Record<string, unknown>}>

apps/web/src/routes/concepts/$conceptId.lazy.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,6 @@ const ConceptRoute = () => {
7676
entityId={conceptId || ''}
7777
displayName={concept.display_name || "Concept"}
7878
selectParam={typeof selectParam === 'string' ? selectParam : undefined}
79-
selectFields={selectFields || []}
8079
viewMode={viewMode}
8180
onViewModeChange={setViewMode}
8281
data={concept}>

apps/web/src/routes/domains/$domainId.lazy.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,6 @@ const DomainRoute = () => {
8080
entityId={fullDomainId}
8181
displayName={domain.display_name || "Domain"}
8282
selectParam={typeof selectParam === 'string' ? selectParam : undefined}
83-
selectFields={selectFields || []}
8483
viewMode={viewMode}
8584
onViewModeChange={setViewMode}
8685
data={domain}>

apps/web/src/routes/fields/$fieldId.lazy.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,6 @@ const FieldRoute = () => {
8080
entityId={fullFieldId}
8181
displayName={field.display_name || "Field"}
8282
selectParam={typeof selectParam === 'string' ? selectParam : undefined}
83-
selectFields={selectFields || []}
8483
viewMode={viewMode}
8584
onViewModeChange={setViewMode}
8685
data={field}>

apps/web/src/routes/funders/$funderId.lazy.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ const FunderRoute = () => {
7373
entityId={funderId}
7474
displayName={funder.display_name || "Funder"}
7575
selectParam={(selectParam as string) || ''}
76-
selectFields={selectFields || []}
7776
viewMode={viewMode}
7877
onViewModeChange={setViewMode}
7978
data={funder as Record<string, unknown>}

apps/web/src/routes/institutions/$_.lazy.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,6 @@ const InstitutionRoute = () => {
9090
entityId={decodedInstitutionId}
9191
displayName={institution.display_name || "Institution"}
9292
selectParam={(selectParam as string) || ''}
93-
selectFields={selectFields || []}
9493
viewMode={viewMode}
9594
onViewModeChange={setViewMode}
9695
data={institution as Record<string, unknown>}>

apps/web/src/routes/keywords/$keywordId.lazy.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ const KeywordRoute = () => {
7373
entityId={keywordId || ''}
7474
displayName={keyword.display_name || "Keyword"}
7575
selectParam={typeof selectParam === 'string' ? selectParam : undefined}
76-
selectFields={selectFields || []}
7776
viewMode={viewMode}
7877
onViewModeChange={setViewMode}
7978
data={keyword}>

apps/web/src/routes/publishers/$publisherId.lazy.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ const PublisherRoute = () => {
7373
entityId={publisherId}
7474
displayName={publisher.display_name || "Publisher"}
7575
selectParam={(selectParam as string) || ''}
76-
selectFields={selectFields || []}
7776
viewMode={viewMode}
7877
onViewModeChange={setViewMode}
7978
data={publisher as Record<string, unknown>}

apps/web/src/routes/sources/$sourceId.lazy.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ const SourceRoute = () => {
7171
entityId={sourceId}
7272
displayName={source.display_name || "Source"}
7373
selectParam={(selectParam as string) || ''}
74-
selectFields={selectFields || []}
7574
viewMode={viewMode}
7675
onViewModeChange={setViewMode}
7776
data={source as Record<string, unknown>}>

apps/web/src/routes/subfields/$subfieldId.lazy.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,6 @@ const SubfieldRoute = () => {
8080
entityId={fullSubfieldId}
8181
displayName={subfield.display_name || "Subfield"}
8282
selectParam={typeof selectParam === 'string' ? selectParam : undefined}
83-
selectFields={selectFields || []}
8483
viewMode={viewMode}
8584
onViewModeChange={setViewMode}
8685
data={subfield}>

0 commit comments

Comments
 (0)