Skip to content

Commit b4cbbdb

Browse files
committed
refactor(web): remove barrelsby tool and configuration
- Remove barrelsby dependency from package.json - Remove barrelsby scripts from root package.json - Remove barrelsby task from apps/web/project.json - Update dev target to remove barrelsby dependency - Remove barrelsby-header ESLint rule and file - Update tools/eslint-rules/index.ts to remove barrelsby-header - Update eslint.config.base.ts to remove barrelsby-header reference Fixes issue where pnpm dev command was failing due to missing .barrelsby.json
1 parent 6fd07b6 commit b4cbbdb

File tree

5 files changed

+2
-120
lines changed

5 files changed

+2
-120
lines changed

apps/web/project.json

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -11,25 +11,15 @@
1111
"cwd": "{projectRoot}"
1212
}
1313
},
14-
"barrelsby": {
15-
"executor": "nx:run-commands",
16-
"options": {
17-
"command": "barrelsby --config ../../.barrelsby.json --directory ./src/components",
18-
"cwd": "{projectRoot}"
19-
},
20-
"cache": true
21-
},
2214
"dev": {
2315
"executor": "nx:run-commands",
2416
"options": {
2517
"commands": [
26-
"echo '[barrels:watch] Starting...' && exec nx watch --projects=types,utils,client,ui,algorithms,web -- nx run \\$NX_PROJECT_NAME:barrelsby",
2718
"nx run web:serve"
2819
],
2920
"parallel": true
3021
},
31-
"continuous": true,
32-
"dependsOn": ["barrelsby"]
22+
"continuous": true
3323
},
3424
"test:e2e": {
3525
"executor": "@nx/playwright:playwright",

eslint.config.base.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,8 +171,7 @@ export default tseslint.config([
171171
"barrel-files/avoid-re-export-all": "off", // Turned off - using custom rule instead for more control
172172
"barrel-files/avoid-namespace-import": "off", // Turned off - namespace imports have valid use cases
173173

174-
// Custom rules - prevent re-exports from non-barrel files but make barrels optional
175-
"custom/barrelsby-header": "off", // Turned off - barrels are optional
174+
// Custom rules - prevent re-exports from non-barrel files
176175
"custom/no-deprecated": "error",
177176
"custom/no-duplicate-reexports": "error",
178177
"custom/no-reexport-from-non-barrel": "error", // Keep - prevents re-exports from non-barrels

package.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@
1010
],
1111
"repository": "https://github.com/Mearman/BibGraph.git",
1212
"scripts": {
13-
"barrels": "nx run-many -t barrelsby",
14-
"barrels:dry": "barrelsby --config .barrelsby.json --delete false",
1513
"build": "nx run-many -t build",
1614
"clean": "nx reset && rm -rf dist coverage .nx/cache .tanstack node_modules/.vite && pnpm --filter='*' clean",
1715
"cli": "tsx apps/cli/src/openalex-cli.ts",
@@ -104,7 +102,6 @@
104102
"@vitest/coverage-v8": "4.0.14",
105103
"@vitest/eslint-plugin": "1.5.1",
106104
"@vitest/ui": "4.0.14",
107-
"barrelsby": "2.8.1",
108105
"chokidar": "5.0.0",
109106
"eslint": "9.39.1",
110107
"eslint-config-xo": "0.49.0",

tools/eslint-rules/barrelsby-header.ts

Lines changed: 0 additions & 101 deletions
This file was deleted.

tools/eslint-rules/index.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,13 @@
77

88
import { noDeprecated } from "./no-deprecated.js";
99
import { noRedundantAssignment } from "./no-redundant-assignment.js";
10-
import { barrelsbyHeader } from "./barrelsby-header.js";
1110
import { noDuplicateReexports } from "./no-duplicate-reexports.js";
1211
import { noReexportFromNonBarrel } from "./no-reexport-from-non-barrel.js";
1312

1413
export const customRulesPlugin = {
1514
rules: {
1615
"no-deprecated": noDeprecated,
1716
"no-redundant-assignment": noRedundantAssignment,
18-
"barrelsby-header": barrelsbyHeader,
1917
"no-duplicate-reexports": noDuplicateReexports,
2018
"no-reexport-from-non-barrel": noReexportFromNonBarrel,
2119
},
@@ -24,7 +22,6 @@ export const customRulesPlugin = {
2422
export {
2523
noDeprecated,
2624
noRedundantAssignment,
27-
barrelsbyHeader,
2825
noDuplicateReexports,
2926
noReexportFromNonBarrel,
3027
};

0 commit comments

Comments
 (0)