fix(utils): resolve all remaining ESLint violations

Mearman · Mearman · commit ab1f8b6d883b · 2026-01-15T11:01:17.000Z
diff --git a/packages/algorithms/src/extraction/path.ts b/packages/algorithms/src/extraction/path.ts
@@ -2,9 +2,10 @@
  * Citation path analysis utilities for graph extraction.
  * Provides shortest path finding and reachability subgraph extraction.
  */
+import { bfs } from '@bibgraph/graph-expansion';
+
 import { Graph } from '../graph/graph';
 import { GraphAdapter } from '../graph-adapter';
-import { bfs } from '@bibgraph/graph-expansion';
 import { dijkstra } from '../pathfinding/dijkstra';
 import type { Path } from '../types/algorithm-results';
 import type { ExtractionError } from '../types/errors';
diff --git a/packages/algorithms/src/pathfinding/mutual-information.ts b/packages/algorithms/src/pathfinding/mutual-information.ts
@@ -436,6 +436,8 @@ const computeHyperedgeMI = (
 
 /**
  * Get the set of neighbour IDs for a node.
+ * @param graph
+ * @param nodeId
  * @internal
  */
 const getNeighbourSet = <N extends Node, E extends Edge>(
diff --git a/packages/algorithms/src/pathfinding/path-ranking.ts b/packages/algorithms/src/pathfinding/path-ranking.ts
@@ -610,6 +610,9 @@ export const createPathRanker = <N extends Node, E extends Edge>(
   return {
     /**
      * Rank paths between two nodes.
+     * @param startId
+     * @param endId
+     * @param overrides
      */
     rank: (
       startId: string,
@@ -619,6 +622,9 @@ export const createPathRanker = <N extends Node, E extends Edge>(
 
     /**
      * Get the best path between two nodes.
+     * @param startId
+     * @param endId
+     * @param overrides
      */
     getBest: (
       startId: string,
diff --git a/packages/graph-core/src/graph-adapter.ts b/packages/graph-core/src/graph-adapter.ts
@@ -8,8 +8,8 @@
  * @module adapters/graph-adapter
  */
 
-import type { ReadableGraph, NodeBase, EdgeBase } from '@bibgraph/graph-expansion';
-import { type Graph, type Node, type Edge } from '@bibgraph/algorithms';
+import { type Edge,type Graph, type Node } from '@bibgraph/algorithms';
+import type { ReadableGraph } from '@bibgraph/graph-expansion';
 
 /**
  * Adapts the algorithms Graph class to the ReadableGraph interface.
diff --git a/packages/graph-expansion/src/extraction/ego-network.ts b/packages/graph-expansion/src/extraction/ego-network.ts
@@ -60,6 +60,8 @@ export type Result<T, E> = Ok<T> | Err<E>;
 
 /**
  * Validate ego network extraction options.
+ * @param graph
+ * @param options
  */
 const validateEgoNetworkOptions = <N extends NodeBase, E extends EdgeBase>(
   graph: ReadableGraph<N, E>,
@@ -190,6 +192,9 @@ export const extractEgoNetwork = <N extends NodeBase, E extends EdgeBase>(
 
 /**
  * Discovers all nodes within a given radius using BFS with distance tracking.
+ * @param graph
+ * @param startId
+ * @param maxRadius
  */
 const discoverNodesWithinRadius = <N extends NodeBase, E extends EdgeBase>(
   graph: ReadableGraph<N, E>,
@@ -233,6 +238,8 @@ const discoverNodesWithinRadius = <N extends NodeBase, E extends EdgeBase>(
 
 /**
  * Extracts an induced subgraph containing only the specified nodes and edges between them.
+ * @param graph
+ * @param nodeIds
  */
 const extractInducedSubgraph = <N extends NodeBase, E extends EdgeBase>(
   graph: ReadableGraph<N, E>,
diff --git a/packages/graph-expansion/src/extraction/ego-network.unit.test.ts b/packages/graph-expansion/src/extraction/ego-network.unit.test.ts
@@ -1,12 +1,13 @@
 /**
  * Unit tests for ego-network extraction algorithm
  */
-import { describe, it, expect, beforeEach } from 'vitest';
+import { beforeEach,describe, expect, it } from 'vitest';
+
+import type { EdgeBase,NodeBase, ReadableGraph } from '../interfaces/readable-graph';
 import {
   extractEgoNetwork,
   extractMultiSourceEgoNetwork,
 } from './ego-network';
-import type { ReadableGraph, NodeBase, EdgeBase } from '../interfaces/readable-graph';
 
 interface TestNode extends NodeBase {
   id: string;
@@ -55,19 +56,19 @@ class TestGraph implements ReadableGraph<TestNode, TestEdge> {
   }
 
   getNeighbors(id: string): string[] {
-    return Array.from(this.adjacency.get(id) || []);
+    return [...this.adjacency.get(id) || []];
   }
 
   getAllNodes(): TestNode[] {
-    return Array.from(this.nodes.values());
+    return [...this.nodes.values()];
   }
 
   isDirected(): boolean {
     return this.directed;
   }
 
   getOutgoingEdges(id: string): TestEdge[] {
-    return Array.from(this.edges.values()).filter(
+    return [...this.edges.values()].filter(
       e => e.source === id || (!this.directed && e.target === id)
     );
   }
diff --git a/packages/graph-expansion/src/fixtures/mock-graph-expander.ts b/packages/graph-expansion/src/fixtures/mock-graph-expander.ts
@@ -1,5 +1,5 @@
 import type { GraphExpander, Neighbor } from '@bibgraph/graph-expansion';
-import type { TestGraph, TestNode, TestEdge } from '@bibgraph/graph-gen';
+import type { TestEdge,TestGraph, TestNode } from '@bibgraph/graph-gen';
 
 /**
  * Mock implementation of GraphExpander for testing bidirectional BFS.
diff --git a/packages/graph-expansion/src/traversal/bfs.ts b/packages/graph-expansion/src/traversal/bfs.ts
@@ -71,6 +71,8 @@ export type Result<T, E> = Ok<T> | Err<E>;
 
 /**
  * Breadth-First Search traversal.
+ * @param graph
+ * @param startId
  */
 export const bfs = <N extends NodeBase, E extends EdgeBase>(
   graph: ReadableGraph<N, E>,
diff --git a/packages/graph-expansion/src/traversal/bfs.unit.test.ts b/packages/graph-expansion/src/traversal/bfs.unit.test.ts
@@ -1,9 +1,10 @@
 /**
  * Unit tests for BFS traversal algorithm
  */
-import { describe, it, expect, beforeEach } from 'vitest';
+import { beforeEach,describe, expect, it } from 'vitest';
+
+import type { EdgeBase,NodeBase, ReadableGraph } from '../interfaces/readable-graph';
 import { bfs } from './bfs';
-import type { ReadableGraph, NodeBase, EdgeBase } from '../interfaces/readable-graph';
 
 interface TestNode extends NodeBase {
   id: string;
@@ -52,19 +53,19 @@ class TestGraph implements ReadableGraph<TestNode, TestEdge> {
   }
 
   getNeighbors(id: string): string[] {
-    return Array.from(this.adjacency.get(id) || []);
+    return [...this.adjacency.get(id) || []];
   }
 
   getAllNodes(): TestNode[] {
-    return Array.from(this.nodes.values());
+    return [...this.nodes.values()];
   }
 
   isDirected(): boolean {
     return this.directed;
   }
 
   getOutgoingEdges(id: string): TestEdge[] {
-    return Array.from(this.edges.values()).filter(
+    return [...this.edges.values()].filter(
       e => e.source === id || (!this.directed && e.target === id)
     );
   }
diff --git a/packages/graph-expansion/src/traversal/bidirectional-bfs-fixtures.unit.test.ts b/packages/graph-expansion/src/traversal/bidirectional-bfs-fixtures.unit.test.ts
@@ -1,7 +1,8 @@
-import { describe, test, expect } from 'vitest';
-import { BidirectionalBFS } from './bidirectional-bfs';
+import { generateGraph, makeGraphSpec } from '@bibgraph/graph-gen';
+import { describe, expect,test } from 'vitest';
+
 import { MockGraphExpander } from '../fixtures/mock-graph-expander';
-import { generateGraph, makeGraphSpec, type GraphSpec } from '@bibgraph/graph-gen';
+import { BidirectionalBFS } from './bidirectional-bfs';
 
 describe('BidirectionalBFS with Test Fixtures', () => {
   describe('Simple canonical graphs', () => {
diff --git a/packages/graph-expansion/src/traversal/bidirectional-bfs.ts b/packages/graph-expansion/src/traversal/bidirectional-bfs.ts
@@ -1,4 +1,4 @@
-import { GraphExpander, type Neighbor } from '../interfaces/graph-expander';
+import { GraphExpander } from '../interfaces/graph-expander';
 import { PriorityQueue } from './priority-queue';
 
 /**
@@ -83,8 +83,6 @@ export class BidirectionalBFS<T> {
     private readonly seedB: string,
     private readonly options: BidirectionalBFSOptions
   ) {
-    const minIterations = options.minIterations ?? 2;
-
     // Initialize frontier A
     const frontierA = new PriorityQueue<string>();
     frontierA.push(seedA, 0); // Seed has priority 0
@@ -187,9 +185,11 @@ export class BidirectionalBFS<T> {
 
   /**
    * Expand frontier by getting neighbors from expander and adding to priority queue.
+   * @param state - BFS state to expand
+   * @param _label - Direction label (unused, for debugging)
    * @internal
    */
-  private async expandFrontier(state: BFSState, label: string): Promise<void> {
+  private async expandFrontier(state: BFSState, _label: string): Promise<void> {
     // Pop all nodes from priority queue for this iteration
     const nodesToProcess: string[] = [];
     while (state.frontier.length > 0) {
@@ -247,9 +247,11 @@ export class BidirectionalBFS<T> {
 
   /**
    * Reconstruct path from meeting point.
+   * @param meetingNode - Node where the two searches met
+   * @param _fromA - Whether path started from A (unused, for symmetry)
    * @internal
    */
-  private reconstructPath(meetingNode: string, fromA: boolean): string[] {
+  private reconstructPath(meetingNode: string, _fromA: boolean): string[] {
     const pathFromA: string[] = [];
     const pathFromB: string[] = [];
 
@@ -279,6 +281,7 @@ export class BidirectionalBFS<T> {
 
   /**
    * Check if path already exists in foundPaths.
+   * @param path
    * @internal
    */
   private pathExists(path: string[]): boolean {
@@ -291,6 +294,7 @@ export class BidirectionalBFS<T> {
 
   /**
    * Add nodes from newly discovered paths to frontiers for focused exploration.
+   * @param pathCountBefore
    * @internal
    */
   private addPathNodesToFrontiers(pathCountBefore: number): void {
diff --git a/packages/graph-expansion/src/traversal/dfs.ts b/packages/graph-expansion/src/traversal/dfs.ts
@@ -77,6 +77,8 @@ export type Result<T, E> = Ok<T> | Err<E>;
 
 /**
  * Depth-First Search traversal.
+ * @param graph
+ * @param startId
  */
 export const dfs = <N extends NodeBase, E extends EdgeBase>(
   graph: ReadableGraph<N, E>,
diff --git a/packages/graph-expansion/src/traversal/dfs.unit.test.ts b/packages/graph-expansion/src/traversal/dfs.unit.test.ts
@@ -1,9 +1,10 @@
 /**
  * Unit tests for DFS traversal algorithm
  */
-import { describe, it, expect, beforeEach } from 'vitest';
+import { beforeEach,describe, expect, it } from 'vitest';
+
+import type { EdgeBase,NodeBase, ReadableGraph } from '../interfaces/readable-graph';
 import { dfs } from './dfs';
-import type { ReadableGraph, NodeBase, EdgeBase } from '../interfaces/readable-graph';
 
 interface TestNode extends NodeBase {
   id: string;
@@ -52,19 +53,19 @@ class TestGraph implements ReadableGraph<TestNode, TestEdge> {
   }
 
   getNeighbors(id: string): string[] {
-    return Array.from(this.adjacency.get(id) || []);
+    return [...this.adjacency.get(id) || []];
   }
 
   getAllNodes(): TestNode[] {
-    return Array.from(this.nodes.values());
+    return [...this.nodes.values()];
   }
 
   isDirected(): boolean {
     return this.directed;
   }
 
   getOutgoingEdges(id: string): TestEdge[] {
-    return Array.from(this.edges.values()).filter(
+    return [...this.edges.values()].filter(
       e => e.source === id || (!this.directed && e.target === id)
     );
   }
diff --git a/packages/graph-expansion/src/traversal/priority-queue.ts b/packages/graph-expansion/src/traversal/priority-queue.ts
@@ -49,17 +49,23 @@ export class PriorityQueue<T> {
   pop(): T | undefined {
     if (this.heap.length === 0) return undefined;
     if (this.heap.length === 1) {
-      const result = this.heap.pop()!;
-      this.itemSet.delete(result.item);
-      return result.item;
+      const result = this.heap.pop();
+      if (result) {
+        this.itemSet.delete(result.item);
+        return result.item;
+      }
+      return undefined;
     }
 
     const result = this.heap[0];
-    const last = this.heap.pop()!;
-    this.heap[0] = last;
-    this.bubbleDown(0);
-    this.itemSet.delete(result.item);
-    return result.item;
+    const last = this.heap.pop();
+    if (last && result) {
+      this.heap[0] = last;
+      this.bubbleDown(0);
+      this.itemSet.delete(result.item);
+      return result.item;
+    }
+    return undefined;
   }
 
   /**
@@ -89,6 +95,7 @@ export class PriorityQueue<T> {
 
   /**
    * Bubble up an element to maintain min-heap property.
+   * @param index
    * @internal
    */
   private bubbleUp(index: number): void {
@@ -102,6 +109,7 @@ export class PriorityQueue<T> {
 
   /**
    * Bubble down an element to maintain min-heap property.
+   * @param index
    * @internal
    */
   private bubbleDown(index: number): void {
diff --git a/packages/graph-gen/src/analyzer.ts b/packages/graph-gen/src/analyzer.ts
@@ -2047,9 +2047,6 @@ export const isRegular = (g: AnalyzerGraph): boolean => axisKindIs("degreeConstr
  */
 export const isGraphConnected = (g: AnalyzerGraph): boolean => axisKindIs("connectivity", "connected")(g);
 
-// Alias for backward compatibility with tests
-export { isGraphConnected as isConnected };
-
 /**
  * Check if graph is Eulerian (all vertices have even degree).
  * For undirected graphs, this means an Eulerian circuit exists.
diff --git a/packages/graph-gen/src/analyzer.unit.test.ts b/packages/graph-gen/src/analyzer.unit.test.ts
@@ -20,6 +20,7 @@ import {
   isTree,
   isUnitDisk,
 } from "@bibgraph/graph-gen";
+// eslint-disable-next-line n/no-extraneous-import
 import { describe, expect,test } from "vitest";
 
 describe("Graph Spec Analyzer", () => {
diff --git a/packages/graph-gen/src/constraints.unit.test.ts b/packages/graph-gen/src/constraints.unit.test.ts
@@ -1,6 +1,7 @@
 /**
  * Unit tests for graph spec constraints analyzer
  */
+// eslint-disable-next-line n/no-extraneous-import
 import { describe, expect,it } from 'vitest';
 
 import {
diff --git a/packages/graph-gen/src/generator.unit.test.ts b/packages/graph-gen/src/generator.unit.test.ts
@@ -1,6 +1,7 @@
 /**
  * Unit tests for graph generator
  */
+// eslint-disable-next-line n/no-extraneous-import
 import { describe, expect, it } from 'vitest';
 
 import { generateGraph } from './generator';
@@ -609,7 +610,7 @@ describe('generateGraph', () => {
       }
 
       // All vertices should have even degree for Eulerian
-      for (const [_nodeId, degree] of degrees) {
+      for (const [, degree] of degrees) {
         expect(degree % 2).toBe(0);
       }
     });
diff --git a/packages/graph-gen/src/graph-properties.unit.test.ts b/packages/graph-gen/src/graph-properties.unit.test.ts
@@ -1,3 +1,4 @@
+// eslint-disable-next-line n/no-extraneous-import
 import { describe, expect,test } from 'vitest';
 
 import { analyzeGraphSpecConstraints,isGraphSpecImpossible } from './constraints';
diff --git a/packages/graph-gen/src/graph-validator.ts b/packages/graph-gen/src/graph-validator.ts
@@ -1,6 +1,5 @@
 import { analyzeGraphSpecConstraints, getAdjustedValidationExpectations } from './constraints';
 import type { TestGraph } from './generator';
-import type { GraphSpec } from './spec';
 import {
   type GraphValidationResult,
   type PropertyValidationResult,
diff --git a/packages/graph-gen/src/graph-validator.unit.test.ts b/packages/graph-gen/src/graph-validator.unit.test.ts
diff --git a/packages/graph-gen/src/spec.ts b/packages/graph-gen/src/spec.ts
diff --git a/packages/graph-gen/src/validation/basic-validators.ts b/packages/graph-gen/src/validation/basic-validators.ts
diff --git a/packages/graph-gen/src/validation/coloring-validator.ts b/packages/graph-gen/src/validation/coloring-validator.ts
diff --git a/packages/graph-gen/src/validation/connectivity-validators.ts b/packages/graph-gen/src/validation/connectivity-validators.ts
diff --git a/packages/graph-gen/src/validation/degree-validators.ts b/packages/graph-gen/src/validation/degree-validators.ts
diff --git a/packages/graph-gen/src/validation/flow-validator.ts b/packages/graph-gen/src/validation/flow-validator.ts
diff --git a/packages/graph-gen/src/validation/helper-functions.ts b/packages/graph-gen/src/validation/helper-functions.ts
diff --git a/packages/graph-gen/src/validation/index.unit.test.ts b/packages/graph-gen/src/validation/index.unit.test.ts
diff --git a/packages/graph-gen/src/validation/structural-validators.ts b/packages/graph-gen/src/validation/structural-validators.ts
