Skip to content

Conversation

@Anaritus
Copy link
Contributor

@Anaritus Anaritus commented Jul 17, 2025

Checkbox completion was always kinda funky at best. This is my attempt at improving it
Here is before:
Kapture 2025-07-18 at 00 52 54
Here is after:
Kapture 2025-07-18 at 01 02 31

Although it is not a complete fix, I think it is worth looking into. Especially considering complete fix would probably involve rewriting the whole logic for completion decision

@MeanderingProgrammer
Copy link
Owner

Hey, thanks for the PR!

Do the extra brackets still appear if you upgrade your version of blink.cmp? I assume that's the completion engine you're using, and in previous versions I saw the same behavior, but doesn't seem to be happening anymore (at least for me).

@MeanderingProgrammer
Copy link
Owner

I believe this change in blink.cmp is what fixes the extra brackets: saghen/blink.cmp@5cf9a78

@Anaritus
Copy link
Contributor Author

Aight! Rolled back this change as it does seem to work) Sorry for the slow response, updated all and had to rewrite half my obsidian config .-.

What about the other changes?

@MeanderingProgrammer
Copy link
Owner

Other changes look good, thanks!

@MeanderingProgrammer MeanderingProgrammer merged commit 1128bc3 into MeanderingProgrammer:main Jul 20, 2025
@MeanderingProgrammer
Copy link
Owner

I reworked completions a bit more: 3254863

This handles some more edge cases that this change didn't quite. I'll use the | to indicate the cursor position where completions should be shown but previously weren't.

Inserting a sub list between existing ones:

- test
  - |
    - test

Editing an existing item:

- | test

LMK if you spot any more strange behaviors!

@Anaritus
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants