Skip to content

Commit 97038fd

Browse files
committed
Make sure the ubuntu artifacts do not overwrite each other
- also fix minor readme error
1 parent 1162164 commit 97038fd

File tree

2 files changed

+8
-16
lines changed

2 files changed

+8
-16
lines changed

.github/workflows/build.yml

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@ jobs:
1515
strategy:
1616
fail-fast: false
1717
matrix:
18-
container:
19-
- 'ubuntu:20.04'
20-
- 'ubuntu:22.04'
18+
container_version:
19+
- '20.04'
20+
- '22.04'
2121
runs-on: ubuntu-latest
22-
container: ${{ matrix.container }}
22+
container: ubuntu:${{ matrix.container_version }}
2323
steps:
2424
- name: Install Qt
2525
run: |
@@ -70,16 +70,8 @@ jobs:
7070
7171
- name: Upload Wrappers
7272
uses: actions/upload-artifact@v3
73-
if: ${{ matrix.container }} == 'ubuntu:20.04'
7473
with:
75-
name: wrappers_ubuntu_20_04
76-
path: generated_cpp
77-
78-
- name: Upload Wrappers
79-
uses: actions/upload-artifact@v3
80-
if: ${{ matrix.container }} == 'ubuntu:22.04'
81-
with:
82-
name: wrappers_ubuntu_22_04
74+
name: wrappers_ubuntu_${{ matrix.container_version }}
8375
path: generated_cpp
8476

8577
oldschool:

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ the directory where the python lib file is located. Then you should set the
4343
When using the prebuild Python installer, this will be:
4444

4545
```cmd
46-
set PYTHON_PATH=c:\Python38
47-
set PYTHON_LIB=c:\Python38\libs
48-
set PYTHON_VERSION=38
46+
set PYTHON_PATH=c:\Python311
47+
set PYTHON_LIB=c:\Python311\libs
48+
set PYTHON_VERSION=3.11
4949
```

0 commit comments

Comments
 (0)