Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetching of title + description when editing a link URL is a little aggressive #464

Open
andrewmoise opened this issue Jan 29, 2024 · 1 comment
Labels
bug Something isn't working frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end

Comments

@andrewmoise
Copy link
Contributor

Describe the bug

  • Post a link
  • Paste the URL
  • Start backspacing over stuff from the end of the URL that you don't want to include
  • On pretty much every keypress, a dialog pops up saying "Are you sure you want to fetch the title and description? This will overwrite the current values."

On which Mbin instance did you find the bug?

mbin.grits.dev
Version as of git 2024-01-29

Expected behavior

I think more expected would be to pop the warning up when your focus leaves the box. Maybe if you made an edit, and the box was empty before you made the edit, it should pop the dialog immediately, but if the box wasn't empty previously it should wait until the box loses focus before popping up the dialog.

Also the message in the box is a little unclear -- seems like something like "Would you like to fetch the title / description from the provided URL, replacing the current values?" with a yes or no option.

@andrewmoise andrewmoise added the bug Something isn't working label Jan 29, 2024
@andrewmoise andrewmoise changed the title Fetching of title + description when posting a link is a little aggressive Fetching of title + description when editing a link URL is a little aggressive Jan 29, 2024
@BentiGorlich BentiGorlich added the frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end label Jan 31, 2024
@melroy89
Copy link
Member

Feel free to create a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end
Projects
Status: Backlog
Development

No branches or pull requests

3 participants