Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSA always enabled in 4.0 #8147

Closed
4 of 5 tasks
daverodgman opened this issue Sep 1, 2023 · 4 comments
Closed
4 of 5 tasks

PSA always enabled in 4.0 #8147

daverodgman opened this issue Sep 1, 2023 · 4 comments
Labels
api-break This issue/PR breaks the API and must wait for a new major version component-psa PSA keystore/dispatch layer (storage, drivers, …) enhancement size-l Estimated task size: large (2w+)

Comments

@daverodgman
Copy link
Contributor

daverodgman commented Sep 1, 2023

@daverodgman
Copy link
Contributor Author

See #5156 for earlier discussion on this

@daverodgman daverodgman added size-m Estimated task size: medium (~1w) component-psa PSA keystore/dispatch layer (storage, drivers, …) api-break This issue/PR breaks the API and must wait for a new major version enhancement and removed component-psa PSA keystore/dispatch layer (storage, drivers, …) api-break This issue/PR breaks the API and must wait for a new major version size-m Estimated task size: medium (~1w) labels Oct 11, 2023
@mpg
Copy link
Contributor

mpg commented Oct 31, 2023

I think we also want to identify test code that becomes redundant. For example, a lot of things are tested both with and without USE_PSA_CRYPTO, quite a few things tested with PSA_CRYPTO_C disabled, etc.

My gut feeling is that this task is larger than M - it's the kind of thing that looks easy on paper but where you tend to run into surprises. So, I'd be inclined to split it into smaller tasks - I think the first three items could be one task each.

Also, I agree with leaving some parts (remove dead code) to follow-up tasks but I'd strongly advise we address those tasks ASAP. One of the expected benefits of this work is to make maintenance easier, and we don't fully get that while there's still a lot of dead code around.

@gilles-peskine-arm
Copy link
Contributor

I think we also want to identify test code that becomes redundant

Test code will be removed when we remove dead code, based on searching for #if defined and requires_config_enabled and the like. Test cases will be identified by outcome analysis, thanks to #9593.

@gilles-peskine-arm
Copy link
Contributor

We have now created issues for each part, so this planning issue is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-break This issue/PR breaks the API and must wait for a new major version component-psa PSA keystore/dispatch layer (storage, drivers, …) enhancement size-l Estimated task size: large (2w+)
Projects
Status: Mbed TLS 4.0 MUST
Status: Done
Status: No status
Development

No branches or pull requests

3 participants