Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test triggering the second carry in secp384r1 #7309

Closed
yanesca opened this issue Mar 17, 2023 · 1 comment
Closed

Add test triggering the second carry in secp384r1 #7309

yanesca opened this issue Mar 17, 2023 · 1 comment
Labels
component-crypto Crypto primitives and low-level interfaces enhancement size-s Estimated task size: small (~2d)

Comments

@yanesca
Copy link
Contributor

yanesca commented Mar 17, 2023

Suggested enhancement

Triggering the second carry in mbedtls_ecp_mod_p384_raw() might or might not be possible. If it is possible, we need to add a test to trigger this case, if it is not, we need to record the proof in git history it and remove the unused code.

Neither of these tasks are trivial. After some preliminary investigation it seems likely that such case exists.

Justification

Mbed TLS needs this to complete the test coverage of this function or alternatively remove the unnecessary code and save some code size.

@yanesca yanesca added enhancement component-crypto Crypto primitives and low-level interfaces size-s Estimated task size: small (~2d) labels Mar 17, 2023
@yanesca
Copy link
Contributor Author

yanesca commented Mar 17, 2023

Closing it as resolved: #7222 (comment)

@yanesca yanesca closed this as completed Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-crypto Crypto primitives and low-level interfaces enhancement size-s Estimated task size: small (~2d)
Projects
None yet
Development

No branches or pull requests

1 participant