Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move functions from psa_crypto_helpers.h to a .c file #3606

Open
gilles-peskine-arm opened this issue Aug 25, 2020 · 3 comments
Open

Move functions from psa_crypto_helpers.h to a .c file #3606

gilles-peskine-arm opened this issue Aug 25, 2020 · 3 comments
Labels

Comments

@gilles-peskine-arm
Copy link
Contributor

tests/include/test/psa_crypto_helpers.h contains function definitions. That's a remnant from when we didn't have tests/src/*.c and unit tests had to be compiled as a monolithic C file. It's a problem because merely including the header causes an unused-function warning. The header should contain only function declarations (or static inline function definitions, but the functions in that header don't need to be inline).

@YanivBir
Copy link

Hi, Can I work on it? @gilles-peskine-arm

@gilles-peskine-arm
Copy link
Contributor Author

Hi @YanivBir , yes, if you're willing, we'd be grateful. No one is working on this at the moment.

@YanivBir
Copy link

Ok, I'm working on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants