From ec4c47f62b73c83b0f80c8b6f7fe93448c138e83 Mon Sep 17 00:00:00 2001 From: David Horstmann Date: Fri, 8 Dec 2023 18:27:48 +0000 Subject: [PATCH] Move MPI initialization to start of function This prevents a call to mbedtls_mpi_free() on uninitialized data when USE_PSA_INIT() fails. Signed-off-by: David Horstmann --- tests/suites/test_suite_x509write.function | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/suites/test_suite_x509write.function b/tests/suites/test_suite_x509write.function index ad0f2a6f594..90c2192eda7 100644 --- a/tests/suites/test_suite_x509write.function +++ b/tests/suites/test_suite_x509write.function @@ -435,10 +435,11 @@ void x509_set_serial_check() mbedtls_mpi serial_mpi; uint8_t invalid_serial[MBEDTLS_X509_RFC5280_MAX_SERIAL_LEN + 1]; + mbedtls_mpi_init(&serial_mpi); + USE_PSA_INIT(); memset(invalid_serial, 0x01, sizeof(invalid_serial)); - mbedtls_mpi_init(&serial_mpi); TEST_EQUAL(mbedtls_mpi_read_binary(&serial_mpi, invalid_serial, sizeof(invalid_serial)), 0); TEST_EQUAL(mbedtls_x509write_crt_set_serial(&ctx, &serial_mpi),