Detect support for shipped VS solution files

This separates their detection from shipped Makefiles.

Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>

Author: bensze01

src/org/mbed/tls/jenkins/BranchInfo.groovy

@@ -54,8 +54,11 @@ class BranchInfo {
     /** All of the Visual Studio versions supported by this branch */
     public List<String> supported_vs_versions
 
-    /** Whether this branch supports builds using legacy, non-CMake build systems */
-    boolean supports_legacy_build_systems
+    /** Whether this branch has shipped Makefiles */
+    public boolean has_shipped_makefiles
+
+    /** Whether this branch has shipped Visual Studio solution files */
+    public boolean has_shipped_vs_solutions
 
     /** Keep track of builds that fail */
     final Set<String> failed_builds
@@ -73,7 +76,8 @@ class BranchInfo {
         this.python_requirements_override_content = ''
         this.python_requirements_override_file = ''
         this.supported_vs_versions = []
-        this.supports_legacy_build_systems = false
+        this.has_shipped_makefiles = false
+        this.has_shipped_vs_solutions = false
         this.failed_builds = []
         this.outcome_stashes = []
         this.coverage_details = 'Code coverage job did not run'

vars/common.groovy

@@ -277,7 +277,8 @@ List<BranchInfo> get_branch_information(Collection<String> tls_branches, Collect
                             info.supported_vs_versions = ['2017']
 
                             // Detect support for legacy build systems (< Mbed TLS 4.0)
-                            info.supports_legacy_build_systems = fileExists('Makefile')
+                            info.has_shipped_makefiles    = fileExists('Makefile')
+                            info.has_shipped_vs_solutions = fileExists('visualc/VS2017')
                         }
 
                         String platform = linux_platforms[0]

vars/gen_jobs.groovy

@@ -321,7 +321,7 @@ def gen_windows_testing_job(BranchInfo info, String toolchain) {
     def prefix = "${info.prefix}Windows-${toolchain}"
     def build_configs, arches, build_systems, retargeted
     if (toolchain == 'mingw') {
-        if (!info.supports_legacy_build_systems) {
+        if (!info.has_shipped_makefiles) {
             // The mingw toolchain uses the legacy shipped Makefiles
             return [:]
         }
@@ -332,7 +332,7 @@ def gen_windows_testing_job(BranchInfo info, String toolchain) {
     } else {
         build_configs = ['Release', 'Debug']
         arches = ['Win32', 'x64']
-        build_systems = info.supports_legacy_build_systems ? ['shipped', 'cmake'] : ['cmake']
+        build_systems = info.has_shipped_vs_solutions ? ['shipped', 'cmake'] : ['cmake']
         retargeted = [false, true]
     }