enhance common_config.py and generate_test_code.py #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
valeriosetti
force-pushed
the
enhance-config-py
branch
from
868837f
to
1e0a462
Compare
gilles-peskine-arm
added
needs-review
gilles-peskine-arm
requested changes
Sep 25, 2024
gilles-peskine-arm
added
needs-work
and removed
needs-review
valeriosetti
added
needs-review
valeriosetti
changed the title
gilles-peskine-arm
requested changes
Oct 3, 2024
gilles-peskine-arm
added
needs-work
and removed
needs-review
valeriosetti
added
needs-review
valeriosetti
force-pushed
the
enhance-config-py
branch
from
ccd7e87
to
c22ac32
Compare
gilles-peskine-arm
removed
the
needs-reviewer
Both commands use regex expressions to get a list of symbols. The difference between the 2 is that: - get-all returns both enabled and commented out symbols while - get-all-enabled returns only enabled ones. Signed-off-by: Valerio Setti <vsetti@baylibre.com>
Signed-off-by: Valerio Setti <vsetti@baylibre.com>
Signed-off-by: Valerio Setti <vsetti@baylibre.com>
In case of depends_on elements that include a conditional check on some symbol's value, we allow the comparison element to be anything and not just a fixed value as it was before. This allows for more complex depends_on conditions where build symbols and macros are used on both sides of the comparison. Signed-off-by: Valerio Setti <vsetti@baylibre.com>
Do not allow values starting with a 0 because they can be either accidentally octal or accidentally decimal. Hex values are not affected by this change. Signed-off-by: Valerio Setti <vsetti@baylibre.com>
Signed-off-by: Valerio Setti <vsetti@baylibre.com>
Signed-off-by: Valerio Setti <vsetti@baylibre.com>
valeriosetti
force-pushed
the
enhance-config-py
branch
from
42758fc
to
bf87497
Compare
5 tasks
|
@bensze01 sorry to bother you, but this PR is gating the merge of Mbed-TLS/mbedtls#9302 and Mbed-TLS/mbedtls#9448. Can you please take a look at it when you have some spare review bandwidth? |
bensze01
requested changes
Oct 11, 2024
bensze01
added
needs-work
and removed
needs-review
"\w" already matches "[a-zA-Z0-9_]" so CONDITION_VALUE_REGEX can be simplified as proposed in this commit. Signed-off-by: Valerio Setti <vsetti@baylibre.com>
valeriosetti
added
needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend
common_config.pyaddingget-allandget-all-enabledcommands. Both commands use regex expressions to get a list of symbols. The difference between the 2 is that:Enhance
generate_test_code.pyallowing more complex expressions to be used independs_onfields of*.datafiles.These new features are used in Mbed-TLS/mbedtls#9302 and Mbed-TLS/mbedtls#9448