-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance common_config.py and generate_test_code.py #48
Conversation
868837f
to
1e0a462
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from the unnecessary complexity of returning None
when given no regex.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except I'd like to keep rejecting 0123
literals in dependencies.
ccd7e87
to
c22ac32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Both commands use regex expressions to get a list of symbols. The difference between the 2 is that: - get-all returns both enabled and commented out symbols while - get-all-enabled returns only enabled ones. Signed-off-by: Valerio Setti <vsetti@baylibre.com>
Signed-off-by: Valerio Setti <vsetti@baylibre.com>
Signed-off-by: Valerio Setti <vsetti@baylibre.com>
In case of depends_on elements that include a conditional check on some symbol's value, we allow the comparison element to be anything and not just a fixed value as it was before. This allows for more complex depends_on conditions where build symbols and macros are used on both sides of the comparison. Signed-off-by: Valerio Setti <vsetti@baylibre.com>
Do not allow values starting with a 0 because they can be either accidentally octal or accidentally decimal. Hex values are not affected by this change. Signed-off-by: Valerio Setti <vsetti@baylibre.com>
Signed-off-by: Valerio Setti <vsetti@baylibre.com>
Signed-off-by: Valerio Setti <vsetti@baylibre.com>
42758fc
to
bf87497
Compare
@bensze01 sorry to bother you, but this PR is gating the merge of Mbed-TLS/mbedtls#9302 and Mbed-TLS/mbedtls#9448. Can you please take a look at it when you have some spare review bandwidth? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit, otherwise looks good to me.
"\w" already matches "[a-zA-Z0-9_]" so CONDITION_VALUE_REGEX can be simplified as proposed in this commit. Signed-off-by: Valerio Setti <vsetti@baylibre.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Extend
common_config.py
addingget-all
andget-all-enabled
commands. Both commands use regex expressions to get a list of symbols. The difference between the 2 is that:Enhance
generate_test_code.py
allowing more complex expressions to be used independs_on
fields of*.data
files.These new features are used in Mbed-TLS/mbedtls#9302 and Mbed-TLS/mbedtls#9448