Skip to content

Commit a0d7531

Browse files
authored
[wasm] perf: Use node 16.x, and update v8 paths to track that (dotnet#90113)
1 parent e857642 commit a0d7531

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

eng/pipelines/coreclr/templates/run-performance-job.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,12 +64,12 @@ jobs:
6464
- ${{ if eq(parameters.runtimeType, 'wasm') }}:
6565
- HelixPreCommandsWasmOnLinux: >-
6666
sudo apt-get -y remove nodejs &&
67-
curl -fsSL https://deb.nodesource.com/setup_14.x | sudo -E bash - &&
67+
curl -fsSL https://deb.nodesource.com/setup_16.x | sudo -E bash - &&
6868
sudo apt-get -y install nodejs &&
6969
npm install --prefix $HELIX_WORKITEM_PAYLOAD jsvu -g &&
7070
$HELIX_WORKITEM_PAYLOAD/bin/jsvu --os=linux64 --engines=v8 &&
7171
find ~/.jsvu -ls &&
72-
~/.jsvu/engines/v8/v8 -e 'console.log(`V8 version: ${this.version()}`)'
72+
~/.jsvu/bin/v8 -e 'console.log(`V8 version: ${this.version()}`)'
7373
- ${{ if ne(parameters.runtimeType, 'wasm') }}:
7474
- HelixPreCommandsWasmOnLinux: echo
7575
- HelixPreCommandStemWindows: 'set ORIGPYPATH=%PYTHONPATH%;py -m pip install -U pip;py -3 -m venv %HELIX_WORKITEM_PAYLOAD%\.venv;call %HELIX_WORKITEM_PAYLOAD%\.venv\Scripts\activate.bat;set PYTHONPATH=;py -3 -m pip install -U pip;py -3 -m pip install urllib3==1.26.15;py -3 -m pip install azure.storage.blob==12.0.0;py -3 -m pip install azure.storage.queue==12.0.0;set "PERFLAB_UPLOAD_TOKEN=$(HelixPerfUploadTokenValue)"'

eng/testing/performance/performance-setup.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -412,7 +412,7 @@ if [[ -n "$wasm_bundle_directory" ]]; then
412412
fi
413413

414414
# Workaround: escaping the quotes around `--wasmArgs=..` so they get retained for the actual command line
415-
extra_benchmark_dotnet_arguments="$extra_benchmark_dotnet_arguments --wasmEngine /home/helixbot/.jsvu/$javascript_engine --wasmArgs \\\"$wasm_args\\\" --cli \$HELIX_CORRELATION_PAYLOAD/dotnet/dotnet --wasmDataDir \$HELIX_CORRELATION_PAYLOAD/wasm-data"
415+
extra_benchmark_dotnet_arguments="$extra_benchmark_dotnet_arguments --wasmEngine /home/helixbot/.jsvu/bin/$javascript_engine --wasmArgs \\\"$wasm_args\\\" --cli \$HELIX_CORRELATION_PAYLOAD/dotnet/dotnet --wasmDataDir \$HELIX_CORRELATION_PAYLOAD/wasm-data"
416416
if [[ "$wasmaot" == "true" ]]; then
417417
extra_benchmark_dotnet_arguments="$extra_benchmark_dotnet_arguments --aotcompilermode wasm --buildTimeout 3600"
418418
fi

0 commit comments

Comments
 (0)