Skip to content

Commit 0b9768d

Browse files
committed
In JavaScriptEngineSwitcher.ChakraCore improved a implementation of the Dispose method
1 parent 9019798 commit 0b9768d

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

src/JavaScriptEngineSwitcher.ChakraCore/ChakraCoreJsEngine.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1109,9 +1109,9 @@ public override void Dispose()
11091109
/// managed objects contained in fields of class</param>
11101110
private void Dispose(bool disposing)
11111111
{
1112-
if (_disposedFlag.Set())
1112+
if (disposing)
11131113
{
1114-
if (disposing)
1114+
if (_disposedFlag.Set())
11151115
{
11161116
if (_dispatcher != null)
11171117
{
@@ -1130,10 +1130,10 @@ private void Dispose(bool disposing)
11301130
_documentNameManager = null;
11311131
_promiseContinuationCallback = null;
11321132
}
1133-
else
1134-
{
1135-
DisposeUnmanagedResources();
1136-
}
1133+
}
1134+
else
1135+
{
1136+
DisposeUnmanagedResources();
11371137
}
11381138
}
11391139

src/JavaScriptEngineSwitcher.ChakraCore/JavaScriptEngineSwitcher.ChakraCore.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ This package does not contain the native implementations of ChakraCore. Therefor
3131
* JavaScriptEngineSwitcher.ChakraCore.Native.osx-x64</Description>
3232
<PackageTags>$(PackageCommonTags);ChakraCore</PackageTags>
3333
<PackageIconFullPath>../../Icons/JavaScriptEngineSwitcher_ChakraCore_Logo128x128.png</PackageIconFullPath>
34-
<PackageReleaseNotes>ChakraCore was updated to version 1.11.24 (Tomáš Deml's patch applied).</PackageReleaseNotes>
34+
<PackageReleaseNotes>Improved a implementation of the `Dispose` method.</PackageReleaseNotes>
3535
</PropertyGroup>
3636

3737
<ItemGroup>

src/JavaScriptEngineSwitcher.ChakraCore/readme.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
=============
3232
RELEASE NOTES
3333
=============
34-
ChakraCore was updated to version 1.11.24 (Tomáš Deml's patch applied).
34+
Improved a implementation of the `Dispose` method.
3535

3636
=============
3737
DOCUMENTATION

0 commit comments

Comments
 (0)