Try fixing the tests.

Author: mdorman

Cask

@@ -8,4 +8,4 @@
  "get-cabal-configuration.hs")
 
 (development
- (depends-on "cl-lib"))
+ (depends-on "cl-lib" "dash"))

test/flycheck-haskell-test.el

@@ -28,6 +28,7 @@
 (require 'flycheck-haskell)
 
 (require 'cl-lib)
+(require 'dash)
 (require 'ert)
 
 
@@ -54,6 +55,10 @@
   `(unwind-protect (progn ,@body)
      (flycheck-haskell-clear-config-cache)))
 
+(defun flycheck-haskell-compare-sets (actual expected)
+  "Compare ACTUAL and EXPECTED ignoring ordering."
+  (should (equal '() (-difference actual expected))))
+
 
 ;;; Test cases
 
@@ -98,33 +103,33 @@
     (should (= (hash-table-count flycheck-haskell-config-cache) 0))))
 
 (ert-deftest flycheck-haskell-read-cabal-configuration/has-all-extensions ()
-  (should (equal (assq 'extensions (flycheck-haskell-read-test-config))
-                 '(extensions "OverloadedStrings"
-                              "YouDontKnowThisOne"
-                              "GeneralizedNewtypeDeriving"))))
+  (flycheck-haskell-compare-sets (assq 'extensions (flycheck-haskell-read-test-config))
+                                  '(extensions "OverloadedStrings"
+                                               "YouDontKnowThisOne"
+                                               "GeneralizedNewtypeDeriving")))
 
 (ert-deftest flycheck-haskell-read-cabal-configuration/has-all-languages ()
-  (should (equal (assq 'languages (flycheck-haskell-read-test-config))
-                 '(languages "Haskell98" "SpamLanguage" "Haskell2010"))))
+  (flycheck-haskell-compare-sets (assq 'languages (flycheck-haskell-read-test-config))
+                                  '(languages "Haskell98" "SpamLanguage" "Haskell2010")))
 
 (ert-deftest flycheck-haskell-read-cabal-configuration/source-dirs ()
   (let* ((builddirs '("lib/" "." "src/"))
          (expanddir (lambda (fn)
                       (file-name-as-directory
                        (expand-file-name fn flycheck-haskell-test-dir)))))
-    (should (equal
-             (assq 'source-directories (flycheck-haskell-read-test-config))
-             (cons 'source-directories (-map expanddir builddirs))))))
+    (flycheck-haskell-compare-sets
+     (assq 'source-directories (flycheck-haskell-read-test-config))
+     (cons 'source-directories (-map expanddir builddirs)))))
 
 (ert-deftest flycheck-haskell-read-cabal-configuration/build-dirs ()
   (let* ((distdir (expand-file-name "dist/" flycheck-haskell-test-dir))
          (expanddir (lambda (fn) (expand-file-name fn distdir)))
          (builddirs '("build" "build/autogen"
                  "build/flycheck-haskell-unknown-stuff/flycheck-haskell-unknown-stuff-tmp"
                  "build/flycheck-haskell-test/flycheck-haskell-test-tmp")))
-    (should (equal
-             (assq 'build-directories (flycheck-haskell-read-test-config))
-             (cons 'build-directories (-map expanddir builddirs))))))
+    (flycheck-haskell-compare-sets
+     (assq 'build-directories (flycheck-haskell-read-test-config))
+     (cons 'build-directories (-map expanddir builddirs)))))
 
 (ert-deftest flycheck-haskell-get-configuration/no-cache-entry ()
   (let* ((cabal-file flycheck-haskell-test-cabal-file))
@@ -156,13 +161,14 @@
 (ert-deftest flycheck-haskell-process-configuration/language-extensions ()
   (with-temp-buffer                     ; To scope the variables
     (flycheck-haskell-process-configuration (flycheck-haskell-read-test-config))
-    (should (equal flycheck-ghc-language-extensions
-                   '("OverloadedStrings"
-                     "YouDontKnowThisOne"
-                     "GeneralizedNewtypeDeriving"
-                     "Haskell98"
-                     "SpamLanguage"
-                     "Haskell2010")))
+    (flycheck-haskell-compare-sets
+     flycheck-ghc-language-extensions
+     '("OverloadedStrings"
+       "YouDontKnowThisOne"
+       "GeneralizedNewtypeDeriving"
+       "Haskell98"
+       "SpamLanguage"
+       "Haskell2010"))
     (should (local-variable-p 'flycheck-ghc-language-extensions))))
 
 (ert-deftest flycheck-haskell-process-configuration/search-path ()
@@ -173,12 +179,12 @@
                       "build/flycheck-haskell-test/flycheck-haskell-test-tmp"))
          (sourcedir (lambda (fn) (file-name-as-directory
                                   (expand-file-name fn flycheck-haskell-test-dir))))
-         (sourcedirs '("lib/" "." "src/")))
+         (sourcedirs '("lib/" "." "src/"))
+         (computed-path (append (-map builddir builddirs)
+                                (-map sourcedir sourcedirs))))
     (with-temp-buffer
       (flycheck-haskell-process-configuration (flycheck-haskell-read-test-config))
-      (should (equal flycheck-ghc-search-path
-                     (append (-map builddir builddirs)
-                             (-map sourcedir sourcedirs))))
+      (flycheck-haskell-compare-sets flycheck-ghc-search-path computed-path)
       (should (local-variable-p 'flycheck-ghc-search-path)))))
 
 (provide 'flycheck-haskell-test)