Remove memory leak #266
Merged
Remove memory leak #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clins1994
reviewed
Nov 7, 2024
Collaborator
clins1994
left a comment
clins1994
left a comment
There was a problem hiding this comment.
Nice find. I would like to see how you found it though. Evidence?
Contributor
Author
|
@clins1994 well, actually I've found it a while ago, when I was testing my app in prod env. It uses this lib to fetch data from TV and refresh it for about 20k symbols. Usage is something like "Create chart -> get data -> delete chart -> repeat for next symbol". And while checking CPU usage I noticed that RAM usage is constantly growing. Then I reviewed lib's code and found that there is a memory leak. After fixing it locally I had no issues with RAM. Found some images with resources usage from that test (like mid-test and at the end): |
Mathieu2301
approved these changes
Nov 7, 2024
clins1994
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this memory leak when my app was running for a long time.