adapter: Keep replica owners in sync with cluster #20812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkosh44
force-pushed
the
managed-cluster-owners
branch
from
57ba0fd
to
23478e0
Compare
This commit ensures that the owner of a managed cluster is always kept in sync with the owner of its replicas. This commit prevents anyone from manually altering the owner of a managed cluster replica. Additionally, whenever the owner of a managed cluster is altered, the owners of the replicas are automatically altered. Fixes MaterializeInc#20792
jkosh44
force-pushed
the
managed-cluster-owners
branch
3 times, most recently
from
919ec78
to
9f0420b
Compare
jkosh44
changed the title
jkosh44
force-pushed
the
managed-cluster-owners
branch
3 times, most recently
from
ec6626c
to
2cdee50
Compare
This commit updates the semantics of cluster replica owners, so that a replica owner is always kept in sync with the cluster owner. Alter the owner of a replica is no longer permitted. This fits into the model of managed clusters, where replicas are part of the same logical object as the cluster. Fixes MaterializeInc#20792
jkosh44
force-pushed
the
managed-cluster-owners
branch
from
2cdee50
to
6b8affe
Compare
ParkMyCar
reviewed
Jul 28, 2023
Comment on lines
-610
to
-614
| vec![( | ||
| SystemObjectId::Object(cluster_id.into()), | ||
| AclMode::CREATE, | ||
| role_id, | ||
| )] |
There was a problem hiding this comment.
Why don't we require this privilege anymore?
There was a problem hiding this comment.
Conceptually, we're changing how we treat creating replica from "creating a new object in a cluster" to "altering an existing cluster". The matches with the design and syntax of managed clusters, which eventually will be the default (or only) cluster type. So the privileges are transitioning from the ability to create something to the ability to alter something. There's no explicit alter privilege, instead you must own an object to alter it.
ParkMyCar
reviewed
Jul 28, 2023
ParkMyCar
approved these changes
Jul 28, 2023
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the semantics of cluster replica owners, so that a
replica owner is always kept in sync with the cluster owner. Alter the
owner of a replica is no longer permitted.
This fits into the model of managed clusters, where replicas are part
of the same logical object as the cluster.
Fixes #20792
Motivation
This PR fixes a recognized bug.
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.