feat: Implement MinVersion() for Constraints. #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinVersion() returns return the lowest version that can possibly match the given constraint.
For examples:
* `MinVersion("1.0.1") = "1.0.1"`
* `MinVersion("=1.0.1") = "1.0.1"`
* `MinVersion("~1.0.1") = "1.0.1"`
* `MinVersion(">1.0.1") = "1.0.2"`
* `MinVersion(">=1.0.1") = "1.0.1"`
* `MinVersion("<2.0.0 >1.0.1") = "1.0.2"`
etc.
The implementation is based on node-semver:
https://github.com/npm/node-semver/blob/main/ranges/min-version.js
One minor difference is how prerelease versions are treated given `>`:
* In node-semver, `MinVersion(">1.0.0-beta') = "1.0.0-beta.0"`
* In the proposed impl, `MinVersion(">1.0.0-beta') = "1.0.0"`
This behavior made more sense to me given how Version("1.0.0-beta").IncPatch() behaves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MinVersion() returns return the lowest version that can possibly match the given constraint.
For examples:
MinVersion("1.0.1") = "1.0.1"MinVersion("=1.0.1") = "1.0.1"MinVersion("~1.0.1") = "1.0.1"MinVersion(">1.0.1") = "1.0.2"MinVersion(">=1.0.1") = "1.0.1"MinVersion("<2.0.0 >1.0.1") = "1.0.2"etc.
The implementation is based on node-semver:
https://github.com/npm/node-semver/blob/main/ranges/min-version.js
One minor difference is how prerelease versions are treated given
>:MinVersion(">1.0.0-beta') = "1.0.0-beta.0"MinVersion(">1.0.0-beta') = "1.0.0"This behavior made more sense to me given how
Version("1.0.0-beta").IncPatch()behaves.