add defaultState to checkbox parameter #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewang7421
changed the title
MasterBel2
requested changes
Sep 2, 2025
Owner
MasterBel2
left a comment
MasterBel2
left a comment
There was a problem hiding this comment.
This is awesome, and great catch on the typo. Wow. First PR on my repo! This is a huge milestone for me. I thought this would never happen!
Thanks for making my day :)
| end | ||
|
|
||
| checkbox:SetChecked(checked) | ||
| action(checkbox, checked) |
Owner
There was a problem hiding this comment.
I'd prefer we don't call this, and leave the caller to decide whether the action needs to be performed to set initial state or not
added 2 commits
September 2, 2025 20:02
This reverts commit 5f1b372.
Author
|
ignore new changes; I pushed them by mistake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a default checked state for checkboxes, and calls the action parameter at initialization.