Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QC assessment is not wroking #6

Open
omaghsoudi opened this issue Jan 30, 2023 · 7 comments
Open

QC assessment is not wroking #6

omaghsoudi opened this issue Jan 30, 2023 · 7 comments

Comments

@omaghsoudi
Copy link

I want to assess your models in our work and compare it with our in-house models. I got the tissue segmentation working with your instructions on the GitHub page, but the QC part does not work. I provided the inputs and it sticks to "Processing <slide_id>.svs" stage after printing these lines (the warning is something normal):
"""
/opt/conda/envs/imaging-compath/lib/python3.8/site-packages/torchvision/models/_utils.py:208: UserWarning: The parameter 'pretrained' is deprecated since 0.13 and will be removed in 0.15, please use 'weights' instead.
warnings.warn(
/opt/conda/envs/imaging-compath/lib/python3.8/site-packages/torchvision/models/_utils.py:223: UserWarning: Arguments other than a weight enum or None for 'weights' are deprecated since 0.13 and will be removed in 0.15. The current behavior is equivalent to passing weights=ResNet18_Weights.IMAGENET1K_V1. You can also use weights=ResNet18_Weights.DEFAULT to get the most up-to-date weights.
warnings.warn(msg)
=> loading checkpoint '/home/checkpoint_106.pth'
=> loaded checkpoint '/home/checkpoint_106.pth' (epoch 107)
slides mpp manually set to 1.0
"""

Is there a trick to pass this step?

@MaryamHaghighat
Copy link
Owner

Are you running the code on GPU?
QC generates multiple outputs, both images and text files.

@omaghsoudi
Copy link
Author

omaghsoudi commented Feb 9, 2023

Yes, I am running the system on a machine with GPU. Should I somehow let the code know that I am using GPU (I do not see any arguments for setting the GPU for quality assessment code)? The tissue segmentation code uses the GPU without any problem, but the output folder has the ".jpg" file; I do not see any text files. That might be the issue!

@omaghsoudi
Copy link
Author

omaghsoudi commented Feb 10, 2023

I ran it one more time to see if it is just slow because of using CPU (although GPU is available); since yesterday morning, it is still in the processing of one slide.

@omaghsoudi
Copy link
Author

omaghsoudi commented Feb 15, 2023

Is there anything that I can do?

@MaryamHaghighat
Copy link
Owner

MaryamHaghighat commented Feb 15, 2023

We have tested this on a CPU only device for a large cohort and it shouldn't take that long at all! Can you please check Line 136 in "quality-assessment/run.py"? Do you see the message "Processing YourSlideName"? For debugging you can simply comment out process_tiles (line 148).
This will skip processing the slide but then should generate empty files and images quickly. If you still get no output, there should be a problem with the initial configuration. Are you running this on a TCGA slide?

@omaghsoudi
Copy link
Author

omaghsoudi commented Feb 17, 2023

Sorry, I got really busy with a couple of tasks.

Can you please check Line 136 in "quality-assessment/run.py"? Do you see the message "Processing YourSlideName"?

Yes, I see that

For debugging you can simply comment out process_tiles (line 148). This will skip processing the slide but then should generate empty files and images quickly.

I did this and it generated the output images, and it did it really fast.

Are you running this on a TCGA slide?

No, we have our own slides, but they are from both Philips and leica, and they are normal images.

@omaghsoudi
Copy link
Author

We have tested this on a CPU only device for a large cohort and it shouldn't take that long at all! Can you please check Line 136 in "quality-assessment/run.py"? Do you see the message "Processing YourSlideName"? For debugging you can simply comment out process_tiles (line 148). This will skip processing the slide but then should generate empty files and images quickly. If you still get no output, there should be a problem with the initial configuration. Are you running this on a TCGA slide?

Is there anything we can do to fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants