-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Mellow Fly E3 Pro V3 (STM32F407VG) #26214
base: bugfix-2.1.x
Are you sure you want to change the base?
✨Mellow Fly E3 Pro V3 (STM32F407VG) #26214
Conversation
Since this is a duplicate PR, it'd be better to send PRs to #25894 / https://github.com/IoakeimSogiakas/Marlin/tree/FLY_RRF_MARLIN |
i've sent a message to the author but not heard anything back. |
That’s not how it generally works. Users collaborate via a single PR/fork, not open multiple PRs. |
PR #25894 closed, superseded with this on of this one |
I guess that settles that. |
original pr was not finished and seems to be abandoned. this is a step forward |
@ellensp thanks |
As far as I'm concerned this is ready to merge |
anything else i need to do with this? |
be patent, main developer is taking a break for an unknown period of time |
@jaysuk can you update this to work with the latest bugfix-2.1.x and push new changes? If so we should be able to do a final review of this and get it in soon. |
@sjasonsmith updated to the latest. only had to change the boards file |
I also just pushed 55a109e to fix a few small things in |
thanks, didn't even think to check those. Once this is merged I will move on to the next board. I still have the Fly-CDYv3 and Super8 boards to do in the F4 range. Then its on to the H7 ones |
Should be ≤ 20 chars to prevent cutoff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that this supports a lot of peripherals with custom pinouts, such as motor expanders and various temperature sensors.
How confident are you that all of these are correct for this board?
i checked all the pins against the pinouts of the modules etc. |
c624e13
to
e6f1b07
Compare
9c65146
to
4f65466
Compare
PR has been brought up to date & I've pushed some more updates to |
* Add DIAG jumper flag * Assert TMC2209 defaults * Update SDCARD connection format
I just discovered this note about the Mellow Fly E3 Pro V3's thermistor pull-ups: Important The Fly-E3-Pro-v3 uses a 2k2 resistor on the thermistor inputs rather than 4k7. Please make sure you add R2200 to each M308 in your config I ran into this while working on LDO Leviathan board support and it means that users will have select thermistor 1000 for any thermistor they want to use and will have to define all the custom thermistor 1000 parameters found in I also saw the note about needing to add jumpers on Z2's output (I assume they are driven in series?), so adding a warning to the pins file would be a good idea. |
c792921
to
37fb26b
Compare
37d77d6
to
aa44542
Compare
Description
Based on the Fly-E3-v2 mainboard that was merged into Marlin, this is for the Fly-E3-Pro-V3
Requirements
A Fly-E3-Pro-V3
Benefits
Adds support for the Fly-E3-Pro-V3 board
Configurations
Related Issues
None