Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Postprocessing for J-axis checks I-axis instead #26954

Closed
1 task done
hm2dev opened this issue Apr 9, 2024 · 4 comments
Closed
1 task done

[BUG] Postprocessing for J-axis checks I-axis instead #26954

hm2dev opened this issue Apr 9, 2024 · 4 comments

Comments

@hm2dev
Copy link
Contributor

hm2dev commented Apr 9, 2024

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

When defining a configuration of a printer/cnc with an x, y, z and j axis, but no i axis (e.g. because the rotary axis is parallel to y and not to x), compiling fails because

a) a typo in

#if I_E_INDEX >= MAX_E_STEPPERS || !PIN_EXISTS(J_STEP)

which I assume should be #if J_E_INDEX >= MAX_E_STEPPERS || !PIN_EXISTS(J_STEP) instead.
b) the way the code in
#ifdef W_DRIVER_TYPE
and following makes assumptions of the number of axes.
#elif defined(J_DRIVER_TYPE)

Compilation fails with

Marlin\src\pins\pins_postprocess.h:1166:8: error: #error "No E stepper plug left for I!"
    #error "No E stepper plug left for I!"

Bug Timeline

unknown

Expected behavior

Compilation should succeed with only J and no I axis.

Actual behavior

Comilation fails, with

Marlin\src\pins\pins_postprocess.h:1166:8: error: #error "No E stepper plug left for I!"
   #error "No E stepper plug left for I!"

Steps to Reproduce

  1. Define a configuration with no i axis and with j axis.
  2. Compile

Version of Marlin Firmware

2.1.x

Printer model

not relevant. Example Board: MINIRAMBO_CNC

Electronics

MINIRAMBO_CNC

LCD/Controller

ULTIPANEL

Other add-ons

none

Bed Leveling

None

Your Slicer

None

Host Software

None

Don't forget to include

  • A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

Configuration_adv.zip

@hm2dev
Copy link
Contributor Author

hm2dev commented Apr 9, 2024

Upon further investigating and thinking about the axes b) might be working as designed and can be "fixed" by renaming the I axis to B in configuration.h instead of defining an J axis without an I axis.

#define AXIS4_NAME 'A' // :['A', 'B', 'C', 'U', 'V', 'W']

This leaves the typo from a) as bug.
I changed the title accordingly.

If that is so, I can provide a pull request fixing the typo.

@hm2dev hm2dev changed the title [BUG] Not possible to define J axis without I axis [BUG] Postprocessing for J-axis checks I-axis instead Apr 9, 2024
@ellensp
Copy link
Contributor

ellensp commented Apr 9, 2024

Yes in Marlin the internal axis names must be used sequentially. You then give it the external name you want.

Yes that is a typo you found.

@ellensp
Copy link
Contributor

ellensp commented Apr 17, 2024

A pr has been created to fix this typo.

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants