Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] S-curve deceleration lost steps #26861

Closed
1 task done
zhuxiufei opened this issue Mar 11, 2024 · 6 comments
Closed
1 task done

[BUG] S-curve deceleration lost steps #26861

zhuxiufei opened this issue Mar 11, 2024 · 6 comments

Comments

@zhuxiufei
Copy link

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

I tested the S-curve. In the deceleration stage, the last deceleration step could not reach the set end speed because of the accuracy of the floating point number conversion. (The cumulative value of deceleration time cannot reach the total deceleration time, but the number of deceleration pulses is reached)

Bug Timeline

No response

Expected behavior

No response

Actual behavior

No response

Steps to Reproduce

No response

Version of Marlin Firmware

marlin 2.1.x

Printer model

No response

Electronics

No response

LCD/Controller

No response

Other add-ons

No response

Bed Leveling

None

Your Slicer

None

Host Software

None

Don't forget to include

  • A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

No response

@thisiskeithb
Copy link
Member

Please download bugfix-2.1.x to test with the latest code and let us know if you're still having this issue.

Also, please attach your configs.

@ellensp
Copy link
Contributor

ellensp commented Mar 11, 2024

And fill out "Steps to Reproduce" in detail.

@zhuxiufei
Copy link
Author

run_logs.zip
The S-curve code was stripped, the test could run in linux or arm, and the deceleration was actually detected complete, but did not reach the final_rate problem

@zhuxiufei
Copy link
Author

zhuxiufei commented Mar 11, 2024

If I increase STEPPER_TIMER_RATE, things will improve. I suspect that calc_timer_interval will have a bias in the calculation and that this bias will accumulate,If the deviation between frequency and final_rate at the end of deceleration stage is large, it is easy to produce mechanical impact

@InsanityAutomation
Copy link
Contributor

Can you see if the change in #26881 makes any impact to this, or if we are chasing a separate issue?

@thisiskeithb thisiskeithb changed the title [BUG] (bug summary)s-curve deceleration Lost step [BUG] S-curve deceleration lost steps May 16, 2024
Copy link

Greetings from the Marlin AutoBot!
This issue has had no activity for the last 90 days.
Do you still see this issue with the latest bugfix-2.1.x code?
Please add a reply within 14 days or this issue will be automatically closed.
To keep a confirmed issue open we can also add a "Bug: Confirmed" tag.

Disclaimer: This is an open community project with lots of activity and limited
resources. The main project contributors will do a bug sweep ahead of the next
release, but any skilled member of the community may jump in at any time to fix
this issue. That can take a while depending on our busy lives so please be patient,
and take advantage of other resources such as the MarlinFirmware Discord to help
solve the issue.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants