-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] can't disable SDSUPPORT with DWIN_CREALITY_LCD #22716
Comments
Since that LCD runs its own firmware, it cannot be reconfigured on the fly. Thus it has requirements. One is you NEED to have support enabled. |
I've been testing @The-EG's work #22211 for months and it's never been a problem. Only when I switched back to CrealityUI did it become a problem. When I use DWIN_MARLINUI_* everything works. |
The MarlinUI and 'Creality'UI implementations are completely separate. It would appear that the CrealityUI assumes that SDSupport always exists, where the MarlinUI implementation does not. |
The CrealityUI assumes that you have a 3D printer from them, but could be easy for someone to put some #ifdef to disable the menus and functionalities not available without a SD card. The PR #22211 uses the native MarlinUI implementation used in normal LCD display, which is more generic, and can work without a SD card. Maybe your requirement is more a "Feature Request" than a Bug. |
You can disable the need for sdsupport in marlin, but all the SDsupport related icons and features will still be on screen. Resulting in bug reports that the icons/features don't work! |
There's now a sanity check to alert users of the required settings: b0a9107
|
The better options for maximum flexibility are |
As for flexibility, I totally agree with you.
Could they be transferred to the MarlinUI? |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Did you test the latest
bugfix-2.0.x
code?Yes, and the problem still exists.
Bug Description
When I disable SDSUPPORT and want to use DWIN_CREALITY_LCD, I get the following error message when compiling:
Bug Timeline
No response
Expected behavior
No response
Actual behavior
No response
Steps to Reproduce
Compile FW for
#define MOTHERBOARD BOARD_CREALITY_V4
with//#define SDSUPPORT
and#define DWIN_CREALITY_LCD
.Version of Marlin Firmware
bugfix-2.0.x (2021-09-05)
Printer model
Creality Ender 3v2
Electronics
No response
Add-ons
No response
Bed Leveling
UBL Bilinear mesh
Your Slicer
No response
Host Software
OctoPrint
Additional information & file uploads
Configuration.zip
VSCode with
Auto Build Marlin v2.1.34
&PlatformIO IDE v2.3.3
The text was updated successfully, but these errors were encountered: