[BUG] Temperature no longer reported to OctoPrint

[viper93458]

Bug Description

Somewhere between yesterday morning and the most recent merges within 24 hours, OctoPrint can no longer read temperatures from my SKR Pro 1.0. It worked when I used Bugfix 2.0 from yesterday morning sometime (-8 PST) but when I used the latest bugfix this morning the issue cropped up. It causes OctoPrint to disconnect due to multiple timeouts.

Configuration Files

Configs.zip

Steps to Reproduce

Use the current bugfix 2.0 and connect to SKR 1.0 with Octoprint. It appears to connect OK but no temperature data is reported. This causes OctoPrint to throw an error about multiple timeout retires exceeded.

Expected behavior:

Temperatures would display

Actual behavior:

No temperature is displayed and the host disconnects.

Additional Information

I will do my best to provide any additional details as needed. I am not a developer so please be gentle. Thanks for your wonderful work and contributions to 3D printing and Open Source!

[lightmaster]

I was able to roll back to the commit 9e004a9 and it started working again, so it must be something related to PR #20913.

[viper93458]

@lightmaster Thanks for the advise! I'll see if I can accomplish that. Unless a fix comes forth sooner. :)

[TheLion]

I noticed the same thing on my SKR 1.3. I did notice that Octoprint doesn't time out anymore when a print is started.

[GMagician]

I confirm. It seems autotemp report is not working

[GMagician]

After digging into code it seems that is called the template function (empty) instead of overridden one

[Z18Aplha]

Is there a quickfix?

[GMagician]

Not yet, I think @thinkyhead should give a look at code to understand why override is not taking place

[benlye]

Is there a quickfix?

This worked for me (one line change in autoreport.h):
#20913 (comment)

[GMagician]

yep that may solve but I think that virtual will add a cost in its call that is not desired

[gimpfenlord]

Is there a quickfix?

This worked for me (one line change in autoreport.h):
#20913 (comment)

can confirm this worked also for me.

[Z18Aplha]

Is there a quickfix?

This worked for me (one line change in autoreport.h):
#20913 (comment)

thx! i disabled the autoreport timeout in octoprint instead, works fine too. Octoprint polls Temperature now.

[X-Ryl669]

The fix I've proposed is not optimal. We'll find a better solution.

[X-Ryl669]

Can you try #20959, it should solve the building issue and also re-enable auto reporting correctly.

[benlye]

Can you try #20959, it should solve the building issue and also re-enable auto reporting correctly.

Working here.

[viper93458]

Seems to be working for me again so I will close this out. Thanks!

-William

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.