Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOARD_ANET_10 with REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER fails to compile #20680

Closed
ellensp opened this issue Jan 5, 2021 · 1 comment

Comments

@ellensp
Copy link
Contributor

ellensp commented Jan 5, 2021

Bug Description

The Combination of BOARD_ANET_10 with REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER fails to compile.
This is the default for a Anet A6
This is with Current bugfix
The error is: 'DIOLCD_PINS_D7_DDR' was not declared in this scope

Configuration Files

Standard unmodified Anet A6 bugfix example config files
Config files.zip

Steps to Reproduce

  1. Download marlin bugfix
  2. Download marlin bugfix example configurations (or attached config file)
  3. Copy Anet A6 Config files into Marlin
  4. Attempt to compile.

Expected behavior:

It should compile

Actual behavior:

Compiling .pio\build\melzi\src\src\lcd\menu\menu_main.cpp.o
In file included from Marlin\src\lcd\../inc/../HAL/./AVR/HAL.h:22:0,
from Marlin\src\lcd\../inc/../HAL/HAL.h:30,
from Marlin\src\lcd\../inc/MarlinConfig.h:31,
from Marlin\src\lcd\marlinui.cpp:23:
Marlin\src\lcd\marlinui.cpp: In static member function 'static void MarlinUI::init()':
Marlin\src\lcd\../inc/../HAL/./AVR/fastio.h:86:35: error: 'DIOLCD_PINS_D7_DDR' was not declared in this scope

Additional Information

This was raised on Reprap forum https://reprap.org/forum/read.php?415,880180,880182
The cause is PR #19890

The root cause in this PR is in pins_ANET_10.h

#if ENABLED(REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER)
    #define BTN_ENC_EN               LCD_PINS_D7  // Detect the presence of the encoder
  #endif

But LCD_PINS_D7 is not defined for this type of LCD.

@github-actions
Copy link

github-actions bot commented Mar 6, 2021

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant