Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] "One or more timer conflict detected" when trying to compile using mks_robin_nano35_stm32 #20387

Closed
th0m4sek opened this issue Dec 6, 2020 · 10 comments · Fixed by #20545
Assignees

Comments

@th0m4sek
Copy link

th0m4sek commented Dec 6, 2020

Bug Description

`Marlin/src/HAL/STM32/timers.cpp:281:41: error: static assertion failed: One or more timer conflict detected
  281 | static_assert(verify_no_duplicate_timers(), "One or more timer conflict detected");
      |               ~~~~~~~~~~~~~~~~~~~~~~~~~~^~`

same configuration working fine when compiling with mks_robin_nano35
using tmc2209 with uarts connected to one pin.

Configuration Files

Marlinconf.zip

Steps to Reproduce

compile attached files

Expected behavior:

posibility to compile with mks_robin_nano35

Actual behavior:

@th0m4sek
Copy link
Author

th0m4sek commented Dec 8, 2020

Solution from #19905

#if defined(ARDUINO_ARCH_STM32) && !defined(STM32GENERIC)
  // Variant default conflicts with Servo timer
  #define TEMP_TIMER 5
#endif

worked for my MKS Robin Nano V1.2
Maybe this should be merged?

@rhapsodyv
Copy link
Member

@sjasonsmith we can merge it? or it's just a temporary hack?

@sjasonsmith
Copy link
Contributor

I would like to try to find a more flexible way to solve it. As more boards move to the STM32 HAL this will continue to be a problem, and it would be nice to not have to manually define the timer for each board. Not every board should use the same timers for this, due to other conflicts.

@sjasonsmith
Copy link
Contributor

I've updated the provided configs to reproduce the problem using the current state of bugfix-2.0.x.
I tried to preserve all the original settings, but no promises. My goal is just to reproduce the compilation issue.
Configuration.zip

@th0m4sek
Copy link
Author

updated conf on current bugfix is acting as before - can be compiled with mks_robin_nano but not with mks_robin_nano_stm32

@sjasonsmith
Copy link
Contributor

Sorry, I wasn't suggesting that I've fixed it, I just updated them to provide failing configs that work with the current bugfix.

I think I have a more flexible solution semi-ready, but I haven't yet tried it with any hardware. I'm about to post it as a Draft pull request to see if it passes our build tests, and to solicit feedback.

@th0m4sek
Copy link
Author

i was not sure what you wanted to communicate but i wanted to show that i'm ready to help at least with testing ;)

@sjasonsmith
Copy link
Contributor

@th0m4sek I appreciate the willingness to help. I just posted that draft. I'll tag you again when it is ready for you to try out. I'd like to test it with some of my own hardware first.

@sjasonsmith
Copy link
Contributor

This conflict should now be resolved, along with several other boards with similar issues.
I'm closing this, but please let us know if you continue to see issues with the latest changes from bugfix-2.0.x.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants