Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Drilling Canned Cycles feature for CNC #14448

Open
FNeo31 opened this issue Jun 29, 2019 · 2 comments
Open

[FR] Drilling Canned Cycles feature for CNC #14448

FNeo31 opened this issue Jun 29, 2019 · 2 comments
Labels
F: CNC / Laser T: Feature Request Features requested by users.

Comments

@FNeo31
Copy link

FNeo31 commented Jun 29, 2019

Like I talk with @thinkyhead on Discord,
I'm sharing the implementation of Drilling Canned Cycles (G81, G82 and G83)

On Last Bugfix from today just added the call of the cycles on gcode.cpp and gcode.h

add variable on adv cfg:

/**
 * Drilling canned cycles
 * Adds G81, G82 and G83 commands
 */
#define DRILLING_CANNED_CYCLES

and add the attached files of functions.

This drilling cycles aren't optimized and on patterns you need to put the position of new hole and ask for cycle again. This isn't corrected because I don't have too much time to check a solution (one of the reason is the G80 be in use now for other functions).

Wasn't perfect but it's a beginning. :)

drilling cycles.zip

@EvilGremlin
Copy link
Contributor

Maybe post it by pull request?

@boelle
Copy link
Contributor

boelle commented Jul 21, 2019

Thanks for your contribution! Please send as a PR
to the bugfix-2.0.x branch and be careful to target
bugfix-2.0.x when resubmitting the PR.

@boelle boelle added the T: Feature Request Features requested by users. label Jul 21, 2019
@MarlinFirmware MarlinFirmware deleted a comment from github-actions bot Nov 30, 2020
@thinkyhead thinkyhead reopened this Nov 30, 2020
@thinkyhead thinkyhead changed the title [FR] Add Drilling canned cycles to Marlin 2.0 [FR] Drilling Canned Cycles feature for CNC Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F: CNC / Laser T: Feature Request Features requested by users.
Projects
None yet
Development

No branches or pull requests

5 participants