Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [Bugfix 2.0.x] Button not working for pause on stow/deploy with G29 P1 (same with #13114) #13705

Closed
robbycandra opened this issue Apr 15, 2019 · 10 comments

Comments

@robbycandra
Copy link
Contributor

robbycandra commented Apr 15, 2019

Nothing happened when user push the button.
Problem exist in UBL, but not in ABL.

Problem in probe.cpp -> probe_specific_action

        PGM_P const ds_str = deploy ? PSTR(MSG_MANUAL_DEPLOY) : PSTR(MSG_MANUAL_STOW);
        ui.return_to_status();       // To display the new status message
        ui.set_status_P(ds_str, 99);
        serialprintPGM(ds_str);
        SERIAL_EOL();

        KEEPALIVE_STATE(PAUSED_FOR_USER);
        wait_for_user = true;
        #if ENABLED(HOST_PROMPT_SUPPORT)
          host_prompt_do(PROMPT_USER_CONTINUE, PSTR("Stow Probe"), PSTR("Continue"));
        #endif
        while (wait_for_user) idle();
        ui.reset_status();
        KEEPALIVE_STATE(IN_HANDLER);

same with #13114

@robbycandra robbycandra changed the title [bugfix 2.0] Button not working for pause on stow/deploy with G29 P1 (same with #13114) [bugfix 2.0-UBL] Button not working for pause on stow/deploy with G29 P1 (same with #13114) Apr 16, 2019
@jackwilsdon
Copy link
Contributor

I can confirm this is an issue for me too.

@boelle boelle changed the title [bugfix 2.0-UBL] Button not working for pause on stow/deploy with G29 P1 (same with #13114) [BUG] [bugfix 2.0-UBL] Button not working for pause on stow/deploy with G29 P1 (same with #13114) Jul 21, 2019
@boelle boelle closed this as completed Jul 21, 2019
@boelle boelle reopened this Jul 24, 2019
@boelle
Copy link
Contributor

boelle commented Sep 24, 2019

@robbycandra & @jackwilsdon is this still an issue in latest 2.0.x ?

@robbycandra
Copy link
Contributor Author

@boelle , never try again.

@boelle
Copy link
Contributor

boelle commented Oct 12, 2019

Lack of Activity
This issue is being closed due to lack of activity. If you have solved the
issue, please let us know how you solved it. If you haven't, please tell us
what else you've tried in the meantime, and possibly this issue will be
reopened.

@boelle boelle closed this as completed Oct 12, 2019
@timeburn
Copy link
Contributor

This is still an issue in the latest, as of today. ABL is fine, UBL hangs at "Deploy Z-Probe"
Curiously, the deploy/stow works fine for Delta Calibration, just not UBL

@sjasonsmith
Copy link
Contributor

I can also confirm this issue exists, at least on delta. I didn’t realize there was already an issue reported, it was on my lift to report. @boelle, can you re-open this?

@sjasonsmith
Copy link
Contributor

I guess there are others open now too, so as long as one is open we should be good.

@timeburn
Copy link
Contributor

This was solved under issue 15927. my bad for opening a dupe, but it's fixed now

@boelle boelle changed the title [BUG] [bugfix 2.0-UBL] Button not working for pause on stow/deploy with G29 P1 (same with #13114) [BUG] [Bugfix 2.0.x] Button not working for pause on stow/deploy with G29 P1 (same with #13114) Nov 24, 2019
@boelle
Copy link
Contributor

boelle commented Dec 2, 2019

closing since its solved

This was solved under issue 15927.

@boelle boelle closed this as completed Dec 2, 2019
@github-actions
Copy link

github-actions bot commented Jul 3, 2020

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants