Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Equal BigDecimal with different scale will not pass shouldEqual assertion #114

Closed
kostya-misura opened this issue Aug 1, 2018 · 4 comments
Closed

Equal BigDecimal with different scale will not pass shouldEqual assertion #114

kostya-misura opened this issue Aug 1, 2018 · 4 comments

Comments

@kostya-misura
Copy link

BigDecimals should be compared using compareTo operator, otherwise two BigDecimals with different scales will be considered to be different values.

Relevant discussion on Stack Overflow.
@MarkusAmshove
Copy link
Owner

Thanks for reporting, I'll get onto it :-)

@MarkusAmshove MarkusAmshove mentioned this issue Aug 6, 2018
Merged
14 tasks
@MarkusAmshove
Copy link
Owner

Can you have a look over the tests in PR #116 if I'm working correctly with BigDecimal?

@kostya-misura
Copy link
Author

I've added some comments to the PR.

Thanks.

@MarkusAmshove
Copy link
Owner

The changes are now released with v 1.41 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MarkusAmshove @kostya-misura