How to properly wait for _all_ rules to be finished? (Sync and Async)

[ossendorf-at-hoelscher]

We are currently having issues with our asp.net core host which keeps crashing because async rules are still running while CSLA is moving from the server to the client.
This results in the same exceptions as in #3490 described.

So what's currently the correct way/approach to wait on an object to have finished all running rules?
I tried the ValidationComplete but that's no good. It's raised two times. One time for the sync rules to have finished and a second time for the async one. Since I can't know if ever a second raise will come or not that's not a reliable way of telling.
Should I use the IsBusy here? Is that safe?

[rockfordlhotka]

Are you using CheckRulesAsync?

[StefanOssendorf]

Yeah. But setting properties also trigger async rules and how do I wait for these to complete?

[rockfordlhotka]

You aren't using BypassPropertyChecks?

[StefanOssendorf]

No not everywhere.

[rockfordlhotka]

BusinessRules.RunningAsyncRules?

[ossendorf-at-hoelscher]

I'll check that now

[rockfordlhotka]

This console app confirms that all rules (property change and checkrules) complete before the data portal returns from the logical server.

using Csla;
using Csla.Configuration;
using Csla.Rules;
using Microsoft.Extensions.DependencyInjection;

var services = new ServiceCollection();
services.AddCsla();
var serviceProvider = services.BuildServiceProvider();
var portal = serviceProvider.GetRequiredService<IDataPortal<MyBusinessObject>>();
var obj = await portal.FetchAsync();
Console.WriteLine(obj.Data);

[Serializable]
public class MyBusinessObject : BusinessBase<MyBusinessObject>
{
    public static readonly PropertyInfo<string> DataProperty = RegisterProperty<string>(c => c.Data);
    public string Data
    {
        get { return GetProperty(DataProperty); }
        set { SetProperty(DataProperty, value); }
    }

    protected override void AddBusinessRules()
    {
        base.AddBusinessRules();
        BusinessRules.AddRule(new MyRule { PrimaryProperty = DataProperty });
    }

    [Fetch]
    private async Task Fetch()
    {
        Data = "Fetched";
        await BusinessRules.CheckRulesAsync();
        Console.WriteLine("Fetch completed");
    }
}

public class MyRule : BusinessRuleAsync
{
    protected override async Task ExecuteAsync(IRuleContext context)
    {
        await Task.Delay(5000);
        Console.WriteLine("Rule executed");
    }
}

This is without BypassPropertyChecks, and so isn't efficient, but it demonstrates the point.

[ossendorf-at-hoelscher]

This crashes. Maybe wrong usage (can't rule that out....)
Difference is a child which has an async rule.

using Csla;
using Csla.Configuration;
using Csla.Rules;
using Microsoft.Extensions.DependencyInjection;

var services = new ServiceCollection();
services.AddCsla();
var serviceProvider = services.BuildServiceProvider();
var portal = serviceProvider.GetRequiredService<IDataPortal<MyBusinessObject>>();
var obj = await portal.FetchAsync();
Console.WriteLine(obj.Data);

[Serializable]
public class MyBusinessObject : BusinessBase<MyBusinessObject>
{
    public static readonly PropertyInfo<string> DataProperty = RegisterProperty<string>(c => c.Data);
    public string Data
    {
        get { return GetProperty(DataProperty); }
        set { SetProperty(DataProperty, value); }
    }


    public static readonly PropertyInfo<MyBusinessObject2> SubBOProperty = RegisterProperty<MyBusinessObject2>(c => c.SubBO);
    public MyBusinessObject2 SubBO
    {
        get { return GetProperty(SubBOProperty); }
        set { SetProperty(SubBOProperty, value); }
    }

    protected override void AddBusinessRules()
    {
        base.AddBusinessRules();
        //BusinessRules.AddRule(new MyRule { PrimaryProperty = DataProperty });
    }

    [Fetch]
    private async Task Fetch()
    {
        Data = "Fetched";
        SubBO = await ApplicationContext.GetRequiredService<IChildDataPortal<MyBusinessObject2>>().CreateChildAsync();
        SubBO.Data = "asdbahsdas";
        await BusinessRules.CheckRulesAsync();
        Console.WriteLine("Fetch completed");
    }
}

[Serializable]
public class MyBusinessObject2 : BusinessBase<MyBusinessObject2>
{
    public static readonly PropertyInfo<string> DataProperty = RegisterProperty<string>(c => c.Data);
    public string Data
    {
        get { return GetProperty(DataProperty); }
        set { SetProperty(DataProperty, value); }
    }

    protected override void AddBusinessRules()
    {
        base.AddBusinessRules();
        BusinessRules.AddRule(new MyRule { PrimaryProperty = DataProperty });
    }

    [CreateChild]
    private void CreateChild()
    {
        _ = this;
        Console.WriteLine("CreateChild completed");
    }
}

public class MyRule : BusinessRuleAsync
{
    protected override async Task ExecuteAsync(IRuleContext context)
    {
        await Task.Delay(5000);
        Console.WriteLine("Rule BO2 executed");
    }
}

[rockfordlhotka]

The WaitForIdle feature in CSLA 8 is the key. In the root fetch method:

    [Fetch]
    private async Task Fetch()
    {
        Data = "Fetched";
        SubBO = await ApplicationContext.GetRequiredService<IChildDataPortal<Child>>().CreateChildAsync();
        SubBO.Data = "asdbahsdas";
        await BusinessRules.CheckRulesAsync();
        await WaitForIdle();
        Console.WriteLine("Fetch completed");
    }

[StefanOssendorf]

Okay. That sounds great but should be something within the data portals so a user does not have to worry about that.
What do you think?

[rockfordlhotka]

have started looking at how to call this method from CheckRulesAsync, though perhaps you are right and it should be invoked from the data portal itself, rather than blurring the behavior of ChechRulesAsync.

As I type this, I'm more convinced that it should go into the data portal - and very likely other places like the MVC controller base class.

[rockfordlhotka]

#3755